Skip to content

chore: ActionList use forwardedAs in subcomponents - #6995

Merged
francinelucca merged 7 commits into
mainfrom
chore/actionlist-forward-as-fix
Oct 13, 2025
Merged

chore: ActionList use forwardedAs in subcomponents#6995
francinelucca merged 7 commits into
mainfrom
chore/actionlist-forward-as-fix

Conversation

@francinelucca

@francineluccafrancinelucca commented Oct 13, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Add forwardedAs wrapper to styled-components in ActionList subcomponets to prevent override

Changelog

New

  • Add forwardedAs wrapper to styled-components in ActionList subcomponets to prevent override

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

CopilotAI review requested due to automatic review settings October 13, 2025 15:20
@francinelucca
francinelucca requested a review from a team as a code ownerOctober 13, 2025 15:20
@changeset-bot

changeset-botBot commented Oct 13, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d33bcfc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/styled-reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@francinelucca
Use forwardedAs in ActionList subcomponents
16eb0c2
Update ActionList to use forwardedAs in its subcomponents.
@github-actionsgithub-actionsBot added the staff Author is a staff member label Oct 13, 2025
CopilotAI reviewed Oct 13, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds forwardedAs support to ActionList subcomponents by modifying their type definitions and implementation patterns. The changes enable these components to use custom HTML elements while maintaining styled-components compatibility.

Key changes:

  • Added as?: React.ElementType to type definitions for LinkItem, Group, LeadingVisual, and TrailingVisual components
  • Refactored components to use wrapper pattern that forwards the as prop as forwardedAs to styled components
  • Renamed existing styled components with Styled prefix to distinguish from new wrapper components

Comment threadpackages/styled-react/src/components/ActionList.tsx
Comment threadpackages/styled-react/src/components/ActionList.tsx
Comment threadpackages/styled-react/src/components/ActionList.tsx
Comment threadpackages/styled-react/src/components/ActionList.tsx
francineluccaand others added 5 commits October 13, 2025 11:21
@francinelucca
Update packages/styled-react/src/components/ActionList.tsx
a34f9a8
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@francinelucca
Update packages/styled-react/src/components/ActionList.tsx
f47a570
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@francinelucca
Update packages/styled-react/src/components/ActionList.tsx
1b1e1f1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@francinelucca
Update packages/styled-react/src/components/ActionList.tsx
e82354f
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@francinelucca
displayName correction
d33bcfc
@github-actions
github-actionsBot requested a deployment to storybook-preview-6995 October 13, 2025 15:23 Abandoned
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6995 October 13, 2025 15:32 Inactive
@primer-integration

primer-integrationBot commented Oct 13, 2025

Copy link
Copy Markdown

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/4464

@github-actionsgithub-actionsBot added the integration-tests: failing Changes in this PR cause breaking changes in gh/gh label Oct 13, 2025
@primer-integration

primer-integrationBot commented Oct 13, 2025

Copy link
Copy Markdown

🟢 ci completed with status success.

@github-actionsgithub-actionsBot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Oct 13, 2025
@francinelucca
francinelucca merged commit 2d37fab into mainOct 13, 2025
43 of 44 checks passed
@francinelucca
francinelucca deleted the chore/actionlist-forward-as-fix branch October 13, 2025 17:18
@primerprimerBot mentioned this pull request Oct 13, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@TylerJDevTylerJDevTylerJDev approved these changes

Assignees

No one assigned

Labels

integration-tests: passingChanges in this PR do NOT cause breaking changes in gh/ghstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@francinelucca@TylerJDev