Skip to content

chore: simplify rollup.config.mjs - #7304

Closed
swiing wants to merge 4 commits into
primer:mainfrom
swiing:patch-5
Closed

chore: simplify rollup.config.mjs#7304
swiing wants to merge 4 commits into
primer:mainfrom
swiing:patch-5

Conversation

@swiing

Copy link
Copy Markdown
Contributor

Since #6425, the package only exports ESM modules. As a consequence, the rollup configuration does not need to export an array of configuration objects, and as yet another consequence, there is no need to define a base config that could be shared.

Changed

Refactor rollup configuration to export a simple default object directly instead of an array.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Merge checklist

Since primer#6425, the package only exports ESM modules. As a consequence, the rollup configuration does not need to export an array of configuration objects, and as yet another consequence, there is no need to define a base config that could be shared.
Refactor rollup configuration to export a simple default object directly instead of an array.
@swiing
swiing requested a review from a team as a code ownerDecember 11, 2025 19:58
@swiing
swiing requested a review from jonrohanDecember 11, 2025 19:58
@changeset-bot

changeset-botBot commented Dec 11, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c32d1b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan

Copy link
Copy Markdown
Member

Thanks for the PR, we have another one coming that will cover this though #7300

@jonrohan

Copy link
Copy Markdown
Member

.skip-integration-checks

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Cannot proceed with operation

  • reviewDecision: REVIEW_REQUIRED

All operations from forks must have the required reviews before they can proceed. Please ensure this PR has been reviewed and approved before trying again.

Simplify the rollup configuration for better maintainability.
@github-actions

Copy link
Copy Markdown
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@swiing@jonrohan