Skip to content

perf(SelectPanel): Document acceptable :has() selector usage - #7332

Closed
mattcosta7 wants to merge 1 commit into
mainfrom
perf/selectpanel-has-selector
Closed

perf(SelectPanel): Document acceptable :has() selector usage#7332
mattcosta7 wants to merge 1 commit into
mainfrom
perf/selectpanel-has-selector

Conversation

@mattcosta7

@mattcosta7mattcosta7 commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

Closing - Documentation only, no code change

This PR only adds a comment explaining why an existing :has() selector is acceptable. No actual code or behavior changes.

+ /*+ * NOTE: Uses descendant :has() - input is not direct child of TextInputWrapper+ * due to TextInputInnerVisualSlot wrappers. This is acceptable performance+ * as the search is scoped to this single element's subtree.+ */

While the documentation is helpful, it doesn't warrant a patch release since there's no behavior change.

Added documentation explaining why the :has(input:placeholder-shown) selector is acceptable.
Part of #7312
@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 096d1ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 15, 2025
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@mattcosta7GitHub Codespaces

Copy link
Copy Markdown
ContributorAuthor

Closing - this only adds documentation comments with no code or behavior change.

@primer
primerBot deleted the perf/selectpanel-has-selector branch June 30, 2026 18:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@mattcosta7