Skip to content

Push margin-top of TimelineBody +1px - #7617

Merged
llastflowers merged 3 commits into
mainfrom
llastflowers/6438/timeline-icon-alignment-fix
Mar 4, 2026
Merged

Push margin-top of TimelineBody +1px#7617
llastflowers merged 3 commits into
mainfrom
llastflowers/6438/timeline-icon-alignment-fix

Conversation

@llastflowers

@llastflowersllastflowers commented Mar 3, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Relates to https://github.com/github/primer/issues/6438
Corresponding PVC PR: primer/view_components#3976

Changelog

Changed

Added +1px to the margin-top of TimelineBody to improve visual alignment of elements

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Good test stories:

Merge checklist

CopilotAI review requested due to automatic review settings March 3, 2026 20:23
@llastflowers
llastflowers requested a review from a team as a code ownerMarch 3, 2026 20:23
@changeset-bot

changeset-botBot commented Mar 3, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2acbcc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 3, 2026
@github-actions

github-actionsBot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@llastflowers
Update margin-top of TimelineBody
c326f09
Adjust margin-top of TimelineBody by 1px.
CopilotAI reviewed Mar 3, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts TimelineBody spacing in @primer/react’s Timeline component to improve visual alignment by nudging the top margin down by 1px.

Changes:

  • Updates TimelineBody’s margin-top from var(--base-size-4) to calc(var(--base-size-4) + 1px).
  • Adds a targeted stylelint-disable-next-line primer/spacing for the calc(...) spacing expression.

@github-actions
github-actionsBot requested a deployment to storybook-preview-7617 March 3, 2026 20:28 Abandoned
@llastflowersllastflowers added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 3, 2026
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7617 March 3, 2026 20:38 Inactive
@primer-integration

primer-integrationBot commented Mar 3, 2026

Copy link
Copy Markdown

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/15018

@llastflowersllastflowers added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Mar 3, 2026
@primer-integration

primer-integrationBot commented Mar 3, 2026

Copy link
Copy Markdown

Integration test results from github/github-ui:

Passed CI  Passed
Passed VRT  Passed
Passed Projects  Passed

All checks passed!

@primer
primerBot requested a review from a team as a code ownerMarch 3, 2026 21:01
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 3, 2026
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7617 March 3, 2026 21:12 Inactive
@llastflowersllastflowers added the integration-tests: skipped manually Changes in this PR do not require an integration test label Mar 3, 2026
@llastflowers

llastflowers commented Mar 3, 2026

Copy link
Copy Markdown
ContributorAuthor

Integration tests passed but not reporting for CI. Marking as skipped to unblock

@llastflowersllastflowers mentioned this pull request Mar 3, 2026
Merged
10 tasks
@llastflowers
llastflowers added this pull request to the merge queueMar 4, 2026
Merged via the queue into main with commit 79c855aMar 4, 2026
58 checks passed
@llastflowers
llastflowers deleted the llastflowers/6438/timeline-icon-alignment-fix branch March 4, 2026 00:37
@primerprimerBot mentioned this pull request Mar 3, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jonrohanjonrohanjonrohan approved these changes
@siddharthkpsiddharthkpAwaiting requested review from siddharthkpsiddharthkp is a code owner automatically assigned from primer/engineer-reviewers
@francineluccafrancineluccaAwaiting requested review from francinelucca

Assignees

No one assigned

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpmintegration-tests: skipped manuallyChanges in this PR do not require an integration test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@llastflowers@jonrohan