Skip to content

chore(deps): update @github/relative-time-element to latest versions - #7656

Closed
jonrohan wants to merge 1 commit into
mainfrom
upgrade_relative_time_element
Closed

chore(deps): update @github/relative-time-element to latest versions#7656
jonrohan wants to merge 1 commit into
mainfrom
upgrade_relative_time_element

Conversation

@jonrohan

@jonrohan jonrohan commented Mar 11, 2026

Copy link
Copy Markdown
Member

As part of the bump for PVC, it's now on 5.0 of the relative-time-element. Which caused me to make a temp override in github-ui https://github.com/github/github-ui/pull/15781 to be able to update.

I would be great to get PRC on 5.0 so we can remove the override.

Changelog

New

Changed

@github/relative-time-element@5.0.0

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot

changeset-bot Bot commented Mar 11, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 48314a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jonrohan jonrohan changed the title chore(deps): update @primer/react and @github/relative-time-element to latest versions chore(deps): update @github/relative-time-element to latest versions Mar 11, 2026
@github-actions github-actions Bot added the staff Author is a staff member label Mar 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 11, 2026
@github-actions
github-actions Bot temporarily deployed to storybook-preview-7656 March 11, 2026 22:38 Inactive
@jonrohan jonrohan added the skip changeset This change does not need a changelog label Mar 11, 2026
@jonrohan
jonrohan marked this pull request as ready for review March 12, 2026 20:09
@jonrohan
jonrohan requested a review from a team as a code owner March 12, 2026 20:09
@jonrohan
jonrohan requested review from Copilot and hectahertz March 12, 2026 20:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates @primer/react’s dependency on @github/relative-time-element to v5 to align with upstream usage (e.g. github-ui/PVC) and enable removal of temporary overrides.

Changes:

  • Bump @github/relative-time-element from ^4.5.0 to ^5.0.0 in packages/react.
  • Regenerate package-lock.json to reflect the updated dependency resolution.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/react/package.json Updates the direct dependency range for @github/relative-time-element to v5.
package-lock.json Updates the lockfile entries to resolve @github/relative-time-element@5.0.0 (and associated workspace metadata).

Comment on lines 76 to 79
"dependencies": {
"@github/mini-throttle": "^2.1.1",
"@github/relative-time-element": "^4.5.0",
"@github/relative-time-element": "^5.0.0",
"@github/tab-container-element": "^4.8.2",

Copilot AI Mar 12, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This updates a direct dependency across a major version boundary (^4.x -> ^5.x). Per contributor-docs/versioning.md, increasing a dependency to a newer major version should be treated as a major semver bump for @primer/react; the PR template currently indicates a patch release. Please align the rollout/versioning plan accordingly (and include an appropriate changeset if required for the release).

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is true unfortunately :(

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copilot change the rules 😈

@jonrohan
jonrohan requested a review from francinelucca March 17, 2026 19:31
@jonrohan jonrohan added the integration-tests: skipped manually Changes in this PR do not require an integration test label Mar 17, 2026
@francinelucca
francinelucca removed their request for review March 18, 2026 03:18
@jonrohan jonrohan closed this Mar 19, 2026
@jonrohan
jonrohan deleted the upgrade_relative_time_element branch March 23, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants