Skip to content

add data-component attributes for Avatar, AvatarStack, Banner, & BaseStyles - #7734

Merged
llastflowers merged 17 commits into
mainfrom
llastflowers/6497/AvatarStack
Apr 22, 2026
Merged

add data-component attributes for Avatar, AvatarStack, Banner, & BaseStyles#7734
llastflowers merged 17 commits into
mainfrom
llastflowers/6497/AvatarStack

Conversation

@llastflowers

@llastflowersllastflowers commented Apr 7, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Relates to https://github.com/github/primer/issues/6497

Changelog

New

Add data-component attributes and associated for Avatar, AvatarStack, Banner, & BaseStyles

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot

changeset-botBot commented Apr 7, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ea37cc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 7, 2026
@github-actions

github-actionsBot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

@llastflowersllastflowers changed the title Add data-component for AvatarStackfeat(AvatarStack): add data-component attributes for better accessibilityApr 7, 2026
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7734 April 7, 2026 22:25 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7734 April 7, 2026 22:55 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7734 April 7, 2026 23:08 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7734 April 7, 2026 23:19 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7734 April 7, 2026 23:29 Inactive
francinelucca
francinelucca reviewed Apr 8, 2026
View reviewed changes
Comment threadpackages/react/src/AvatarStack/AvatarStack.test.tsx
Comment on lines +44 to +45
const root = container.querySelector('[data-component="AvatarStack"]')
expect(root).toHaveAttribute('data-align-right', '')

@francineluccafrancineluccaApr 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already being useful! 😛

@github-actions
github-actionsBottemporarily deployed to storybook-preview-7734 April 9, 2026 19:11 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7734 April 9, 2026 19:29 Inactive
@llastflowersllastflowers changed the title feat(AvatarStack): add data-component attributes for better accessibilityadd data-component attributes for Avatar, AvatarStack, Banner, & BaseStylesApr 9, 2026
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7734 April 9, 2026 19:40 Inactive
@llastflowers
llastflowers marked this pull request as ready for review April 10, 2026 16:17
francinelucca
francinelucca requested changes Apr 10, 2026
View reviewed changes

@francineluccafrancinelucca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think after #7734 (comment) we're good to go here 👍🏽

@primerprimer deleted a comment from primer-integrationBotApr 10, 2026
@github-actions
github-actionsBot requested a deployment to storybook-preview-7734 April 10, 2026 22:35 Abandoned
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7734 April 10, 2026 22:46 Inactive
@llastflowersllastflowers added the Canary Release Apply this label when you want CI to create a canary release of the current PR label Apr 10, 2026
francinelucca
francinelucca approved these changes Apr 11, 2026
View reviewed changes

@francineluccafrancinelucca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@llastflowers
Add data-component attributes for several components
0d4323c
Add data-component attributes for Avatar, AvatarStack, Banner, and BaseStyles.
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7734 April 17, 2026 18:26 Inactive
@llastflowersllastflowers added integration-tests: skipped manually Changes in this PR do not require an integration test Canary Release Apply this label when you want CI to create a canary release of the current PR and removed integration-tests: skipped manually Changes in this PR do not require an integration test Canary Release Apply this label when you want CI to create a canary release of the current PR labels Apr 18, 2026
@github-actions
github-actionsBot requested a deployment to storybook-preview-7734 April 22, 2026 18:09 Abandoned
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7734 April 22, 2026 18:19 Inactive
@primer-integration

primer-integrationBot commented Apr 22, 2026

Copy link
Copy Markdown

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/19142

@primer-integration

primer-integrationBot commented Apr 22, 2026

Copy link
Copy Markdown

Integration test results from github/github-ui:

Passed CI  Passed
Passed VRT  Passed
Passed Projects  Passed

All checks passed!

@llastflowers
llastflowers added this pull request to the merge queueApr 22, 2026
Merged via the queue into main with commit 421ebf0Apr 22, 2026
53 checks passed
@llastflowers
llastflowers deleted the llastflowers/6497/AvatarStack branch April 22, 2026 18:53
@primerprimerBot mentioned this pull request Apr 22, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@francineluccafrancineluccafrancinelucca approved these changes
@liuliu-devliuliu-devAwaiting requested review from liuliu-devliuliu-dev is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

Canary ReleaseApply this label when you want CI to create a canary release of the current PRintegration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@llastflowers@francinelucca