Uh oh!
There was an error while loading. Please reload this page.
chore(styled-react): remove Breadcrumbs, Table, Timeline, Truncate from @primer/styled-react - #7773
Conversation
🦋 Changeset detectedLatest commit: e580e99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
Removes unused, deprecated component wrappers from the @primer/styled-react package (and the experimental entrypoint), along with their associated tests and export snapshots.
Changes:
- Removed
Breadcrumbs,Timeline, andTruncateexports and deleted their wrapper implementations from@primer/styled-react. - Removed
Table(DataTable) export and deleted its wrapper implementation from@primer/styled-react/experimental. - Updated browser tests and export snapshots to reflect the removed entrypoints.
Show a summary per file
| File | Description |
|---|---|
| packages/styled-react/src/index.tsx | Removes Breadcrumbs, Timeline, and Truncate exports from the main entrypoint. |
| packages/styled-react/src/experimental.tsx | Removes Table (DataTable) exports from the experimental entrypoint. |
| packages/styled-react/src/components/Breadcrumbs.tsx | Deletes the Breadcrumbs wrapper implementation. |
| packages/styled-react/src/components/Timeline.tsx | Deletes the Timeline wrapper implementation. |
| packages/styled-react/src/components/Truncate.tsx | Deletes the Truncate wrapper implementation. |
| packages/styled-react/src/components/DataTable.tsx | Deletes the DataTable wrapper implementation used for experimentalTable. |
| packages/styled-react/src/tests/primer-react.browser.test.tsx | Removes sx-prop tests for the deleted main-entrypoint components. |
| packages/styled-react/src/tests/primer-react-experimental.browser.test.tsx | Removes Table tests from the experimental-entrypoint test suite. |
| packages/styled-react/src/tests/snapshots/exports.test.ts.snap | Updates export snapshots to remove deleted exports. |
| .changeset/famous-berries-kneel.md | Adds a changeset documenting the removal (currently marked as a patch). |
Copilot's findings
- Files reviewed: 10/10 changed files
- Comments generated: 1
Uh oh!
There was an error while loading. Please reload this page.
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/19154 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Overview
Remove
Breadcrumbs,Table,Timeline, andTruncatecomponents from@primer/styled-react. These components have zero remaining usage and can be safely removed.Usage verification
Changelog
New
None
Changed
None
Removed
Breadcrumbs,Breadcrumb,BreadcrumbsProps,BreadcrumbsItemPropsfrom@primer/styled-reactTable,DataTableContainerProps,TableProps,TableHeadProps,TableBodyProps,TableRowProps,TableHeaderProps,TableCellProps,TableTitleProps,TableSubtitleProps,TableActionsPropsfrom@primer/styled-react/experimentalTimeline,TimelineProps,TimelineItemProps,TimelineBadgeProps,TimelineBodyProps,TimelineBreakPropsfrom@primer/styled-reactTruncate,TruncatePropsfrom@primer/styled-reactRollout strategy
Testing & Reviewing
Merge checklist