Skip to content

data-component adr part 2 - #7776

Merged
llastflowers merged 58 commits into
mainfrom
llastflowers/6497/data-component-ADR-part-2
May 13, 2026
Merged

data-component adr part 2#7776
llastflowers merged 58 commits into
mainfrom
llastflowers/6497/data-component-ADR-part-2

Conversation

@llastflowers

@llastflowersllastflowers commented Apr 23, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Relates to https://github.com/github/primer/issues/6497

Changelog

New

Add data-component attributes and associated tests for Blankslate, BranchName, Breadcrumbs, ButtonGroup, Checkbox, CheckboxGroup, CircleBadge, ConfirmationDialog, CounterLabel, and Dialog.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot

changeset-botBot commented Apr 23, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 07b09df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactMinor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 23, 2026
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7776 April 23, 2026 21:21 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7776 April 23, 2026 21:58 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7776 April 23, 2026 23:29 Inactive
@github-actions
github-actionsBot requested a deployment to storybook-preview-7776 April 23, 2026 23:45 Abandoned
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7776 May 8, 2026 17:57 Inactive
francinelucca
francinelucca requested changes May 11, 2026
View reviewed changes

@francineluccafrancinelucca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment and some previous ones still need to be addressed 🙏🏽

Comment threadpackages/react/src/Dialog/Dialog.tsx Outdated
@llastflowers
update Breadcrumbs to add data-component to Breadcrumbs.MenuItem, add…
02c4a6f
… a next test, and move the location of the data-component in Dialog on FooterButton
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7776 May 11, 2026 19:52 Inactive
@llastflowers
add capability to pass data-component for CheckboxGroup sub-component…
627cada
…s through parents, add new tests, and updateInputValidation to allow data-component=CheckboxGroup.Validation to pass through
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7776 May 11, 2026 20:46 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7776 May 11, 2026 21:31 Inactive
@llastflowersllastflowers added Canary Release Apply this label when you want CI to create a canary release of the current PR and removed Canary Release Apply this label when you want CI to create a canary release of the current PR labels May 11, 2026
@primer-integration

primer-integrationBot commented May 11, 2026

Copy link
Copy Markdown

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/20436

@github-actions
github-actionsBottemporarily deployed to storybook-preview-7776 May 11, 2026 22:03 Inactive
@primer-integration

primer-integrationBot commented May 11, 2026

Copy link
Copy Markdown

Integration test results from github/github-ui:

Passed CI  Passed
Passed VRT  Passed
Passed Projects  Passed

All checks passed!

@github-actions
github-actionsBot requested a deployment to storybook-preview-7776 May 12, 2026 17:24 Abandoned
francinelucca
francinelucca approved these changes May 13, 2026
View reviewed changes

@francineluccafrancinelucca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two improvement suggestion, approving preemptively

Comment threadpackages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroup.tsx Outdated
Comment threadpackages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupValidation.tsx Outdated
@primerprimerBot mentioned this pull request May 13, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jonrohanjonrohanjonrohan approved these changes
@francineluccafrancineluccafrancinelucca approved these changes

Assignees

No one assigned

Labels

Canary ReleaseApply this label when you want CI to create a canary release of the current PRintegration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpmintegration-tests: skipped manuallyChanges in this PR do not require an integration test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@llastflowers@jonrohan@francinelucca