Skip to content

refactor: remove lib, lib-esm references - #7853

Merged
primer[bot] merged 3 commits into
mainfrom
docs/remove-lib-esm-references
May 20, 2026
Merged

refactor: remove lib, lib-esm references#7853
primer[bot] merged 3 commits into
mainfrom
docs/remove-lib-esm-references

Conversation

@joshblack

Copy link
Copy Markdown
Member

Closes#7482

Changelog

New

Changed

  • Remove lib, lib-esm references from project

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

This is an internal change to config files

CopilotAI review requested due to automatic review settings May 19, 2026 16:07
@joshblack
joshblack requested a review from a team as a code ownerMay 19, 2026 16:07
@changeset-bot

changeset-botBot commented May 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fd7f39b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actionsgithub-actionsBot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up remaining build/tooling configuration references to the legacy lib/ and lib-esm/ output folders, aligning the repo with the current dist/-only build output model.

Changes:

  • Remove lib/ and lib-esm/ from Turbo build outputs and from various tooling ignore/exclude lists (ESLint, Stylelint, Prettier, Vitest, setup script).
  • Update an exports-parsing example comment to reference ./dist/* instead of ./lib-esm/*.
Show a summary per file
FileDescription
turbo.jsonDrops lib/** and lib-esm/** from build task outputs.
script/setup-react-19.mtsRemoves lib/lib-esm from glob ignore list; minor write formatting tweak.
packages/react/vitest.config.browser.mtsRemoves lib/lib-esm from Vitest browser exclude list.
packages/react/script/get-export-sizes.cjsUpdates example export-map comment from lib-esm wildcard to dist wildcard.
eslint.config.mjsRemoves lib/lib-esm from global ignore patterns.
.stylelintignoreRemoves lib/lib-esm ignore patterns for CSS.
.prettierignoreRemoves lib/lib-esm ignore patterns.
.gitignoreStops ignoring lib/ and lib-esm/ build folders at repo root.

Copilot's findings

  • Files reviewed: 7/8 changed files
  • Comments generated: 1

Comment threadpackages/react/script/get-export-sizes.cjs
@joshblackjoshblack added skip changeset This change does not need a changelog integration-tests: skipped manually Changes in this PR do not require an integration test labels May 19, 2026
@joshblack
joshblack enabled auto-merge May 19, 2026 21:00
@primer
primerBot disabled auto-merge May 20, 2026 15:53
@primer
primerBot enabled auto-merge May 20, 2026 15:53
@primer
primerBot disabled auto-merge May 20, 2026 15:55
@primer
primerBot enabled auto-merge May 20, 2026 15:55
@primer
primerBot added this pull request to the merge queueMay 20, 2026
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7853 May 20, 2026 19:49 Inactive
Merged via the queue into main with commit e9dc2edMay 20, 2026
53 checks passed
@primer
primerBot deleted the docs/remove-lib-esm-references branch May 20, 2026 19:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpmintegration-tests: skipped manuallyChanges in this PR do not require an integration testskip changesetThis change does not need a changelogstaffAuthor is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lib-esm/ is not used anymore, hence references to it could/should be removed as appropriate

3 participants

@joshblack@siddharthkp