Skip to content

AnchoredOverlay: Disable CSS Anchor Positioning if fallbacks is not supported - #7892

Merged
TylerJDev merged 3 commits into
mainfrom
tylerjdev/disable-css-anchor-no-fallback
May 28, 2026
Merged

AnchoredOverlay: Disable CSS Anchor Positioning if fallbacks is not supported#7892
TylerJDev merged 3 commits into
mainfrom
tylerjdev/disable-css-anchor-no-fallback

Conversation

@TylerJDev

Copy link
Copy Markdown
Member

Disables CSS anchor positioning if position-try-fallbacks or positionVisibility are not supported. This will only disable CSS anchor positioning for a small number of browsers, but will ensure that all users have a level of support, either through CSS anchor positioning or the polyfill.

Changelog

Changed

  • Disable CSS anchor positioning if certain CSS rules are not supported on the current browser.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot

changeset-botBot commented May 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 467c12a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

@github-actions
github-actionsBottemporarily deployed to storybook-preview-7892 May 28, 2026 15:06 Inactive
@TylerJDevTylerJDev added the Canary Release Apply this label when you want CI to create a canary release of the current PR label May 28, 2026
@github-actions
github-actionsBottemporarily deployed to storybook-preview-7892 May 28, 2026 15:16 Inactive
@primer-integration

Copy link
Copy Markdown

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/21756

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables the native CSS anchor-positioning path in AnchoredOverlay unless the browser supports additional related CSS features, ensuring the JS/polyfill positioning path is used in partially-supported browsers.

Changes:

  • Tightened client-side feature detection for native CSS anchor positioning to require position-try-fallbacks and position-visibility support.
  • Added a patch changeset entry documenting the behavioral change.
Show a summary per file
FileDescription
packages/react/src/AnchoredOverlay/AnchoredOverlay.tsxMakes native CSS anchor-positioning opt-in only when additional related CSS features are detected.
.changeset/crazy-kings-sip.mdAdds a patch changeset note for the AnchoredOverlay behavior change.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 2

Comment threadpackages/react/src/AnchoredOverlay/AnchoredOverlay.tsx
Comment threadpackages/react/src/AnchoredOverlay/AnchoredOverlay.tsx
@primer-integration

Copy link
Copy Markdown

Integration test results from github/github-ui:

Passed CI  Passed
Passed VRT  Passed
Passed Projects  Passed

All checks passed!

@TylerJDev
TylerJDev added this pull request to the merge queueMay 28, 2026
Merged via the queue into main with commit 4dd08afMay 28, 2026
54 checks passed
@TylerJDev
TylerJDev deleted the tylerjdev/disable-css-anchor-no-fallback branch May 28, 2026 17:05
@primerprimerBot mentioned this pull request May 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Canary ReleaseApply this label when you want CI to create a canary release of the current PRintegration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpmstaffAuthor is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TylerJDev@joshblack