Skip to content

feat: add React Compiler support for Heading, Link, Pagehead, Portal, and SideNav - #8052

Merged
primer[bot] merged 3 commits into
mainfrom
copilot/react-compiler-primitives
Jun 29, 2026
Merged

feat: add React Compiler support for Heading, Link, Pagehead, Portal, and SideNav#8052
primer[bot] merged 3 commits into
mainfrom
copilot/react-compiler-primitives

Conversation

@joshblack

@joshblackjoshblack commented Jun 24, 2026

Copy link
Copy Markdown
Member

Closes N/A

Changelog

New

N/A

Changed

  • Enabled React Compiler support for Heading, Link, Pagehead, Portal, and SideNav.
  • Added a patch changeset for the rendering performance improvement.

Removed

N/A

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

  • npx eslint --no-cache packages/react/src/Heading/**/*.{ts,tsx} packages/react/src/Link/**/*.{ts,tsx} packages/react/src/Pagehead/**/*.{ts,tsx} packages/react/src/Portal/**/*.{ts,tsx} packages/react/src/SideNav.tsx packages/react/src/__tests__/SideNav*.tsx
  • npm test -- --run packages/react/src/Heading packages/react/src/Link packages/react/src/Pagehead packages/react/src/Portal packages/react/src/__tests__/SideNav.test.tsx packages/react/src/__tests__/SideNav.types.test.tsx
  • npm run build && npm test -- --run && npm run type-check && npm run lint && npm run lint:css && npm run format:diff
  • Storybook started and responded locally at http://localhost:6006.

Merge checklist

  • Added/updated tests (not needed; existing coverage validated)
  • Added/updated documentation (not needed)
  • Added/updated previews (not needed)
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge
  • (GitHub staff only) Integration tests pass at github/github-ui (Learn more about how to run integration tests)

@changeset-bot

changeset-botBot commented Jun 24, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3b6675a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added the staff Author is a staff member label Jun 24, 2026
@github-actions

github-actionsBot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. If this doesn't work, you can also use the original workflow here. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jun 24, 2026
@github-actions
github-actionsBottemporarily deployed to storybook-preview-8052 June 24, 2026 22:11 Inactive
@joshblackjoshblack changed the title feat: add React Compiler support for primitive componentsfeat: add React Compiler support for Heading, Link, Pagehead, Portal, and SideNavJun 24, 2026
@joshblack
joshblack marked this pull request as ready for review June 24, 2026 22:12
@joshblack
joshblack requested a review from a team as a code ownerJune 24, 2026 22:12
CopilotAI reviewed Jun 24, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables React Compiler support for additional @primer/react components by removing them from the opt-out list, and records the user-visible performance improvement via a patch changeset.

Changes:

  • Removed Heading, Link, Pagehead, Portal, and SideNav from the React Compiler “unsupported” ignore patterns.
  • Added a patch changeset describing the resulting rendering performance improvement.
Show a summary per file
FileDescription
packages/react/script/react-compiler.mjsUpdates the React Compiler exclusion list to allow compilation for Heading/Link/Pagehead/Portal/SideNav.
.changeset/react-compiler-primitives.mdAdds a patch changeset entry for the performance improvement.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 1

Comment thread.changeset/react-compiler-primitives.md
@joshblack
joshblack enabled auto-merge June 25, 2026 14:26
@github-actions
github-actionsBottemporarily deployed to storybook-preview-8052 June 25, 2026 15:55 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-8052 June 25, 2026 18:38 Inactive
@primer
primerBot disabled auto-merge June 29, 2026 08:15
@primer
primerBot enabled auto-merge June 29, 2026 08:15
@primer
primerBot disabled auto-merge June 29, 2026 08:16
@primer
primerBot enabled auto-merge June 29, 2026 08:16
@joshblack
feat: add React Compiler support for primitives
c6f96cc
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@joshblack
joshblackforce-pushed the copilot/react-compiler-primitives branch from 93d3a9a to c6f96ccCompareJune 29, 2026 14:56
@github-actions
github-actionsBottemporarily deployed to storybook-preview-8052 June 29, 2026 15:06 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-8052 June 29, 2026 15:18 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-8052 June 29, 2026 16:38 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-8052 June 29, 2026 18:07 Inactive
@primer-integration

primer-integrationBot commented Jun 29, 2026•
edited
Loading

Copy link
Copy Markdown

Integration test results from github/github-ui PR:

Passed CI  Passed
Passed VRT  Passed
Running Projects  Running

@primer
primerBot added this pull request to the merge queueJun 29, 2026
Merged via the queue into main with commit a1b24cfJun 29, 2026
54 of 55 checks passed
@primer
primerBot deleted the copilot/react-compiler-primitives branch June 29, 2026 19:00
@primerprimerBot mentioned this pull request Jun 29, 2026
Merged
CopilotAI added a commit that referenced this pull request Jun 30, 2026
@joshblack
fix: properly resolve merge conflicts in react-compiler.mjs
f8bb6e6
Apply both sets of removals from the merge conflict:
- Our PR: Autocomplete, Banner, Button, ConfirmationDialog, Dialog,
PageLayout, Pagination, UnderlineNav, SelectPanel2
- main (PRs #8052, #8053, #8054): AvatarStack, Checkbox,
CheckboxOrRadioGroup, Heading, Link, Pagehead, Portal, SideNav
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
CopilotAI mentioned this pull request Jun 30, 2026
Closed
13 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@siddharthkpsiddharthkpsiddharthkp approved these changes

Assignees

No one assigned

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpmstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshblack@siddharthkp