Skip to content

chore(Link): remove unnecessary data-hover-color attribute - #8211

Merged
francinelucca merged 4 commits into
mainfrom
chore/remove-unnecessary-prop
Jul 22, 2026
Merged

chore(Link): remove unnecessary data-hover-color attribute#8211
francinelucca merged 4 commits into
mainfrom
chore/remove-unnecessary-prop

Conversation

@francinelucca

@francineluccafrancinelucca commented Jul 21, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Removing as per #5319 (comment)

Also added request for prop removal in next major here https://github.com/github/primer/issues/5430#issuecomment-5039700246

Changelog

Removed

  • unneeded data-hover-color attribute in Link

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

CopilotAI review requested due to automatic review settings July 21, 2026 22:23
@francinelucca
francinelucca requested a review from a team as a code ownerJuly 21, 2026 22:23
@changeset-bot

changeset-botBot commented Jul 21, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9201a7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added the staff Author is a staff member label Jul 21, 2026
@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 21, 2026
@github-actions

github-actionsBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

CopilotAI reviewed Jul 21, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the data-hover-color attribute from the Link component’s rendered output, reverting a previously introduced DOM attribute that is no longer needed.

Changes:

  • Removes data-hover-color={hoverColor} from the rendered Link element.
Show a summary per file
FileDescription
packages/react/src/Link/Link.tsxStops rendering the data-hover-color attribute on Link.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Low

Comment threadpackages/react/src/Link/Link.tsx
@github-actions
github-actionsBot requested a deployment to storybook-preview-8211 July 21, 2026 22:29 Abandoned
@github-actions
github-actionsBot requested a deployment to storybook-preview-8211 July 21, 2026 22:35 Abandoned
@primer

primerBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

1 similar comment
@primer

primerBot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

@github-actions
github-actionsBottemporarily deployed to storybook-preview-8211 July 21, 2026 22:46 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-8211 July 21, 2026 22:58 Inactive
@primer-integration

primer-integrationBot commented Jul 21, 2026

Copy link
Copy Markdown

Integration test results from github/github-ui PR:

Passed CI  Passed
Passed VRT  Passed
Passed Projects  Passed

All checks passed!

siddharthkp
siddharthkp reviewed Jul 22, 2026
View reviewed changes
Comment threadpackages/react/src/Link/Link.tsx
) => {
const {as: Component = 'a', className, inline, muted, hoverColor, ...restProps} = props
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const {as: Component = 'a', className, inline, muted, hoverColor: _hoverColor, ...restProps} = props

@siddharthkpsiddharthkpJul 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question for you, I just merged https://github.com/github/github-ui/pull/27116 yesterday.

If hoverColor did not do anything, is it still a breaking change to remove the prop?

siddharthkp
siddharthkp approved these changes Jul 22, 2026
View reviewed changes

@siddharthkpsiddharthkp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with question

@francinelucca
francinelucca added this pull request to the merge queueJul 22, 2026
Merged via the queue into main with commit a3e669fJul 22, 2026
54 checks passed
@francinelucca
francinelucca deleted the chore/remove-unnecessary-prop branch July 22, 2026 10:27
@primerprimerBot mentioned this pull request Jul 22, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@siddharthkpsiddharthkpsiddharthkp approved these changes
@TylerJDevTylerJDevAwaiting requested review from TylerJDevTylerJDev is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpmstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@francinelucca@siddharthkp