Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/remove-theme-color-schemes.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@primer/react': minor
---

ThemeProvider: Add a CSS-variable-based implementation to `@primer/react/next`
and deprecate the legacy JavaScript theme implementation.
6 changes: 6 additions & 0 deletions .changeset/styled-react-vendor-color-schemes.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@primer/styled-react': patch
---

ThemeProvider: Vendor the legacy `colorSchemes` object so styled theming keeps
working after `@primer/react` removed it from its default theme.
2 changes: 1 addition & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ storybook-static
docs/.cache
docs/public
**/.next/**
packages/react/src/legacy-theme/ts/color-schemes.ts
packages/styled-react/src/legacy-theme/ts/color-schemes.ts

# gh-aw generated files (produced by `gh aw compile`; not hand-editable)
.github/workflows/*.lock.yml
Expand Down
66 changes: 36 additions & 30 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions packages/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
"build:docs:preview": "NODE_OPTIONS=--openssl-legacy-provider script/build-docs preview",
"build:components.json": "tsx script/components-json/build.ts",
"build:hooks.json": "tsx script/hooks-json/build.ts",
"build:precompile-color-schemes": "tsx script/precompile-color-schemes.ts",
"lint:npm": "publint --types",
"lint:react-compiler": "node script/lint-react-compiler.ts",
"storybook": "storybook",
Expand All @@ -64,7 +63,6 @@
],
"files": [
"dist",
"!dist/legacy-theme/ts/colors",
"generated",
"CHANGELOG.md"
],
Expand Down
3 changes: 0 additions & 3 deletions packages/react/script/build
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ set -e
# Clean up
npm run clean

# Generate color schemes
npm run build:precompile-color-schemes

# Generate types for CSS Modules
npm run type-css-modules

Expand Down
31 changes: 0 additions & 31 deletions packages/react/script/precompile-color-schemes.ts

This file was deleted.

8 changes: 6 additions & 2 deletions packages/react/src/ThemeContext.ts
Original file line number Diff line number Diff line change
@@ -1,18 +1,22 @@
import React from 'react'
import type {ColorMode, ColorModeWithAuto, Theme} from './ThemeProvider'

export const ThemeContext = React.createContext<{
export interface ThemeContextValue {
/** @deprecated Use `ThemeProvider` and `useTheme` from `@primer/react/next` to migrate away from JavaScript theme values. */
theme?: Theme
colorScheme?: string
colorMode?: ColorModeWithAuto
resolvedColorMode?: ColorMode
/** @deprecated Use `ThemeProvider` and `useTheme` from `@primer/react/next` to migrate away from JavaScript theme values. */
resolvedColorScheme?: string
dayScheme?: string
nightScheme?: string
setColorMode: React.Dispatch<React.SetStateAction<ColorModeWithAuto>>
setDayScheme: React.Dispatch<React.SetStateAction<string>>
setNightScheme: React.Dispatch<React.SetStateAction<string>>
}>({
}

export const ThemeContext = React.createContext<ThemeContextValue>({
setColorMode: () => null,
setDayScheme: () => null,
setNightScheme: () => null,
Expand Down
119 changes: 16 additions & 103 deletions packages/react/src/ThemeProvider.tsx
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
import React from 'react'
import defaultTheme from './theme'
import deepmerge from 'deepmerge'
import {useSyncedState} from './hooks/useSyncedState'
import {ThemeContext} from './ThemeContext'
import {useTheme} from './useTheme'
import {ThemeProviderBase} from './internal/components/ThemeProviderBase'
import {useThemeProvider} from './internal/hooks/useThemeProvider'
import defaultTheme from './theme'

export const defaultColorMode = 'day'
const defaultDayScheme = 'light'
const defaultNightScheme = 'dark'

// eslint-disable-next-line @typescript-eslint/no-explicit-any
export type Theme = {[key: string]: any}
Expand All @@ -30,128 +27,44 @@ export type ThemeProviderProps = {
contextOnly?: boolean
}

/**
* @deprecated Use `ThemeProvider` from `@primer/react/next` to migrate away from JavaScript theme values.
*/
export const ThemeProvider: React.FC<React.PropsWithChildren<ThemeProviderProps>> = ({children, ...props}) => {
// Get fallback values from parent ThemeProvider (if exists)
const {
theme: fallbackTheme,
colorMode: fallbackColorMode,
dayScheme: fallbackDayScheme,
nightScheme: fallbackNightScheme,
} = useTheme()

// Initialize state
const theme = fallbackTheme ?? defaultTheme

const [colorMode, setColorMode] = useSyncedState(props.colorMode ?? fallbackColorMode ?? defaultColorMode)
const [dayScheme, setDayScheme] = useSyncedState(props.dayScheme ?? fallbackDayScheme ?? defaultDayScheme)
const [nightScheme, setNightScheme] = useSyncedState(props.nightScheme ?? fallbackNightScheme ?? defaultNightScheme)
const systemColorMode = useSystemColorMode()
const resolvedColorMode = resolveColorMode(colorMode, systemColorMode)
const colorScheme = chooseColorScheme(resolvedColorMode, dayScheme, nightScheme)
const {parentValue, value} = useThemeProvider(props)
const theme = parentValue.theme ?? defaultTheme
const {resolvedTheme, resolvedColorScheme} = React.useMemo(
() => applyColorScheme(theme, colorScheme),
[theme, colorScheme],
() => applyColorScheme(theme, value.colorScheme),
[theme, value.colorScheme],
)

const contextValue = React.useMemo(
() => ({
...value,
theme: resolvedTheme,
colorScheme,
colorMode,
resolvedColorMode,
resolvedColorScheme,
dayScheme,
nightScheme,
setColorMode,
setDayScheme,
setNightScheme,
}),
[
resolvedTheme,
colorScheme,
colorMode,
resolvedColorMode,
resolvedColorScheme,
dayScheme,
nightScheme,
setColorMode,
setDayScheme,
setNightScheme,
],
[value, resolvedTheme, resolvedColorScheme],
)

if (props.contextOnly) {
return <ThemeContext.Provider value={contextValue}>{children}</ThemeContext.Provider>
}

return (
<ThemeContext.Provider value={contextValue}>
<div
data-component="ThemeProvider"
data-color-mode={colorMode === 'auto' ? 'auto' : colorScheme.includes('dark') ? 'dark' : 'light'}
data-light-theme={dayScheme}
data-dark-theme={nightScheme}
>
{children}
</div>
</ThemeContext.Provider>
<ThemeProviderBase contextOnly={props.contextOnly} value={contextValue}>
{children}
</ThemeProviderBase>
)
}

function subscribeToSystemColorMode(callback: () => void) {
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
const media = window?.matchMedia?.('(prefers-color-scheme: dark)')
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
media?.addEventListener('change', callback)
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
return () => media?.removeEventListener('change', callback)
}

function useSystemColorMode() {
return React.useSyncExternalStore<ColorMode>(subscribeToSystemColorMode, getSystemColorMode, () => 'day')
}

function getSystemColorMode(): ColorMode {
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
return window?.matchMedia?.('(prefers-color-scheme: dark)')?.matches ? 'night' : 'day'
}

function resolveColorMode(colorMode: ColorModeWithAuto, systemColorMode: ColorMode) {
switch (colorMode) {
case 'auto':
return systemColorMode
default:
return colorMode
}
}

function chooseColorScheme(colorMode: ColorMode, dayScheme: string, nightScheme: string) {
switch (colorMode) {
case 'day':
case 'light':
return dayScheme
case 'dark':
case 'night':
return nightScheme
}
}

function applyColorScheme(
theme: Theme,
colorScheme: string,
): {resolvedTheme: Theme; resolvedColorScheme: string | undefined} {
if (!theme.colorSchemes) {
return {
resolvedTheme: theme,
resolvedColorScheme: undefined,
}
return {resolvedTheme: theme, resolvedColorScheme: undefined}
}

if (!theme.colorSchemes[colorScheme]) {
// eslint-disable-next-line no-console
console.error(`\`${colorScheme}\` scheme not defined in \`theme.colorSchemes\``)

// Apply the first defined color scheme
const defaultColorScheme = Object.keys(theme.colorSchemes)[0]
return {
resolvedTheme: deepmerge(theme, theme.colorSchemes[defaultColorScheme]),
Expand Down
Loading
Loading