Uh oh!
There was an error while loading. Please reload this page.
fix: prevent jruby bundler from installing a test library with native extenstion. - #112
Merged
Conversation
MarcMcIntosh
commented
Jun 14, 2021
ContributorAuthor
So there are a couple of issues here. I would sujest looking for a non-native replacement for nokogiri |
faresd
reviewed
Jun 15, 2021
faresd
left a comment
Contributor
There was a problem hiding this comment.
Hi @MarcMcIntosh I've added few notes, can you check?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This reverts commit 55fa78e. Changes to be committed: modified: .travis.yml
faresd
approved these changes
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there's a dependancy of bundler,
raccthis seems to be creating issues with jruby.Using bundler -v 2.1.4 worked locally now to test it in travis.