Uh oh!
There was an error while loading. Please reload this page.
Attest the box in oprf-mode boot gate and provisioning - #13
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mode = "oprf"units calledkeep frost network oprf-provision/oprf-unlockwithout--tpm-tcti, so the box attached no attestation quote to its requests. Holders gate enrollment and evaluation on a VERIFIED dealer (and refuseNotConfigured), so an unattested box is rejected: provisioning never seals a share and the boot-time unlock fails closed. The end-to-end OPRF test (#10) surfaced the same requirement at the CLI level.Changes
keepNode.frostGate.tpmTctioption (defaultdevice:/dev/tpmrm0): the box's TPM TCTI, used to attach a measured-boot quote so holders can verify this dealer.--tpm-tcti ${cfg.tpmTcti}into both the boot-timeoprf-unlockand the operator-drivenoprf-provisioncalls.keep-node-frost-provision: the box attests during provisioning and every boot unlock, which needs thetpm-attestationkeep-cli build feature and TPM device access (e.g./dev/tpmrm0) on both this unit and the boot gate. Neither unit sandboxes devices, so a default root oneshot already has access; if device sandboxing is added later, allow the TPM (DeviceAllow=/dev/tpmrm0 rw).The module's oprf-mode path still has no nixosTest of its own (tracked separately); this change is validated by
nix eval+ formatting and the existing tpm-modefrost-gatetest (unaffected).