feat(data): expose bridged Binance L2 replay snapshots - #105
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 25 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
87c009e to
6d0d0bc
Compare
Change contract
Expose a deterministic, price-sorted full Binance L2 replay snapshot only after
ReplaySequenceValidatorreaches a bridged state.Acceptance evidence
cargo test --locked -p hft-data(15 passed on merged feat(data): validate Binance market tape #104 base)cargo fmt -p hft-data -- --checkcargo clippy --locked -p hft-data --all-targets -- -D warningscargo check --locked -p hft-data --all-targetsgit diff --checkOut of scope
Tape schema and clock validation (#104), artifact manifest/checksum/compiler wiring, collector changes, databases, L3/order IDs, queue/impact/capacity/fill modeling, and live execution.
Dependency or merge order
None. This change is independently usable and does not depend on #104.
Focused validation
The counterexample test proves an unbridged replay cannot expose a book snapshot. The positive test applies a bridging diff, verifies deletions and updates, and asserts full bid-descending / ask-ascending deterministic output.
Rollout / rollback impact
No runtime wiring or behavior changes until a downstream consumer calls the new method. Roll back by reverting this PR; existing replay validation behavior is unchanged.