Skip to content

Harden Polymarket verifier counterexamples - #108

Merged
proerror77 merged 1 commit into
mainfrom
codex/polymarket-evidence-verifier-tests
Jul 17, 2026
Merged

proerror77 merged 1 commit into
mainfrom
codex/polymarket-evidence-verifier-tests

Conversation

@proerror77

@proerror77 proerror77 commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Change contract

Add focused two-event counterexamples that lock down the existing Polymarket evidence verifier's global identity, duplicate-row, context-consistency, and event-local completeness invariants.

Out of scope

Verifier behavior changes, public API changes, wire decoding, research-snapshot mapping, collector/runtime/deployment work, and live execution.

Dependencies and merge order

Depends on merged #106, then #109. Merge #109 first; after GitHub retargets this PR to main, verify the rebased exact head and merge this test-only layer.

Focused validation

  • cargo fmt --all -- --check
  • cargo test --locked -p ploy-market-data (21 passed)
  • cargo clippy --locked -p ploy-market-data --all-targets --no-deps -- -D warnings
  • Counterexamples cover cross-event condition/token reuse, duplicate trade IDs, duplicate per-event settlements while preserving global manifest counts, row-context contradiction, event-local missing Chainlink reference/trade, and missing settlement rejection at the sealed-manifest boundary.
  • Test review confirmed all three previously reported P2 coverage gaps are resolved.

Rollout and rollback

No production behavior or runtime path changes. Rollback removes only regression evidence; it does not change verifier behavior.

Scope exception

None. One test file, 71 inserted lines.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1e0e4f5d-7ebf-4c3b-aa13-ce527c905338

📥 Commits

Reviewing files that changed from the base of the PR and between 370dbe4 and 15c0514.

📒 Files selected for processing (1)
  • rust_hft/prediction-markets/crates/ploy-market-data/src/polymarket_evidence/verified.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/polymarket-evidence-verifier-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proerror77
proerror77 force-pushed the codex/polymarket-evidence-verified branch from bf02a3a to 02d601d Compare July 17, 2026 19:07
@proerror77
proerror77 force-pushed the codex/polymarket-evidence-verifier-tests branch 2 times, most recently from c48f6ed to 0cd2236 Compare July 17, 2026 19:38
@proerror77
proerror77 changed the base branch from codex/polymarket-evidence-verified to main July 17, 2026 19:38
@proerror77
proerror77 force-pushed the codex/polymarket-evidence-verifier-tests branch from 0cd2236 to 15c0514 Compare July 17, 2026 19:50
@proerror77
proerror77 merged commit a6e24b0 into main Jul 17, 2026
26 checks passed
@proerror77
proerror77 deleted the codex/polymarket-evidence-verifier-tests branch July 17, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant