feat(research): type Campaign recovery checkpoint contracts in Rust - #1104
feat(research): type Campaign recovery checkpoint contracts in Rust#1104proerror77 wants to merge 4 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ffa168c7a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Change
Make the existing learning and generation-completion checkpoint formats explicit Rust contracts under alpha-domain, as the first step toward the Rust Campaign controller. Typed schema versions and outcomes reject drift; intrinsic validation rejects inconsistent child/terminal states.
Four fixtures are original outputs from the existing controller recovery test. The test gains an optional fixture export directory; production bash behavior stays unchanged. Hash checks use original bytes, while round trips check semantic field preservation.
Issue relationship
None
Validation
Updated branch to main
38af0810; original behavior patch is unchanged. On current head3577ff84, all 4 checkpoint tests and all 13 controller recovery scenarios passed. Full-crate results below are from the original behavior commit8e404025.Existing controller test, including 13 process recovery/conflict scenarios: passed; used to generate the fixtures.
cargo test -p alpha-domain --locked: 88 passed, including wire round trip, original-byte hash linkage, schema drift and invalid transition checks. A failing regression proved that missing learning evidence was previously accepted; terminal variants now require coherent learning, report and bound fields.cargo clippy -p alpha-domain --all-targets --locked -- -D warnings: passed.bash -nandgit diff --check: passed.Runtime impact and rollback
No runtime or cloud changes. These are structural contracts, not dispatch authorization or an evidence-readback implementation. Job watch/relist, Lease fencing, and bounded cloud acceptance remain subsequent work. Rollback is a code revert; existing persisted checkpoint bytes remain untouched.