fix(polymarket): keep top-of-book pairs complete - #111
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 30 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Change contract
Normalize each Polymarket top-of-book price/size pair atomically: retain both fields only when both are present and non-null; otherwise publish both as null while preserving full depth levels.
Out of scope
Dependency or merge order
None. This PR is independently mergeable and revertible. The production Linux evidence image should be built only after this PR and #110 are both merged so one image contains both the normalized rows and published digest output.
Focused validation
cargo test -p hft-collector boundary_ -- --nocapturecargo test -p hft-collector --lib(149 passed, 2 ignored before the mirrored counterexample was added; both focused counterexamples pass afterward)cargo clippy -p hft-collector --all-targets --no-deps -- -D warningsrustfmt --edition 2021 --check rust_hft/tools/collector/src/polymarket_research_normalize.rsd13921994f5505c0d8e89ca375dd30035a6c27b49c62e56c5233988bf8fdbb0c.Targeted counterexamples cover both asymmetric failures:
Rollout/rollback impact
Rollout: rebuild the immutable Linux publisher image, republish the bounded evidence window, then require seal and semantic verification to pass before research consumption.
Rollback: revert this PR and keep the verifier fail-closed; do not reuse evidence published with unpaired top-of-book fields.