fix(prediction): fail-close leftover live OMS execution - #1161
Open
proerror77 wants to merge 3 commits into
Open
fix(prediction): fail-close leftover live OMS execution#1161proerror77 wants to merge 3 commits into
proerror77 wants to merge 3 commits into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
proerror77
marked this pull request as ready for review
September 12, 2026 04:58
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Compatibility live submit, cancel, and replace never call a venue client. The leftover live-execution feature is a no-op tombstone, and Live runner mode always exits fail-closed. This does not enable LiveSmall or add a venue adapter. Co-authored-by: Wild Card <proerror77@users.noreply.github.com>
Live submit never acknowledges, so the injected second trading-state write failure cannot exercise an ack path. Keep the test on the fail-closed reject and zero venue submits. Co-authored-by: Wild Card <proerror77@users.noreply.github.com>
The leftover live OMS lockfile edit changed Cargo.lock. Refresh the reviewed ploy-research Linux policy graph input hash and canonical digest so build.rs fail-closes on the current lockfile. Co-authored-by: Wild Card <proerror77@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/fail-close-live-execution-oms-8714
branch
from
September 12, 2026 05:44
92303af to
c34946c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Compatibility live OMS submit, cancel, and replace never call a venue client. They fail closed with
MONDAY_EXECUTION_DISABLED. The leftoverlive-executionCargo feature is an empty tombstone,RuntimeMode::Livealways exits 1, andLiveExecutoris removed. This does not enable LiveSmall and does not add a venue adapter. Monday runtime remains the only production execution authority.The reviewed Linux
ploy-researchpolicy dependency graph is regenerated for the currentCargo.lock(input:Cargo.lock=sha256:20bda65059737c81a42fcd7035184fac7309a1ae34fc48f1dde5819ee154369b).Issue relationship
None
Validation
From
rust_hft/prediction-marketsat the policy-graph commit:cargo test --locked -p ploy-research --lib runtime_identity_uses_a_canonical_checked_in_linux_graph_with_features— passedcargo test --locked -p ploy-platform-runtime --lib— 76 passedcargo test --locked -p ploy-daemon-host --lib— 106 passed, 1 ignoredcargo test --locked -p ploy-strategy-runtime --lib --features liveandlive,live-execution— 5 passed eachCI on pre-rebase
464722dewas green (42 checks). This head rebases those three commits onto currentorigin/main(6fdd7b29/ #1152).Runtime impact and rollback
No LiveSmall enablement and no venue adapter. Compatibility prediction live order paths reject instead of calling a client. Rollback is revert of this PR.