fix(collector): keep Binance tape replay-unsafe

[proerror77]

Change contract
Production startup cannot promote Binance market_tape.v1 artifacts to replay-safe until an authenticated aggregate-trade predecessor or explicit capture epoch exists; the merged collector CI borrow errors are also removed.

Out of scope
Durable aggregate-trade lineage restore, explicit capture-epoch promotion, source-clock skew policy, raw f/l trade-range continuity, verifier/backfill, deployment, and ECS changes.

Dependency or merge order
Follow-up correction to merged PR #117. Merge immediately before any Binance market-tape deployment or verifier promotion. None otherwise.

Focused validation

• cargo test -p hft-collector --features collector-binance --locked: 156 passed, 2 ignored; Binance bin 33 passed
• cargo clippy -p hft-collector --all-targets --features collector-binance --no-deps --locked -- -D warnings
• cargo fmt -p hft-collector -- --check
• git diff --check
• Counterexample: startup_default_keeps_checkpoints_replay_unsafe proves a normal production-default start cannot emit a replay-safe manifest or checkpoint row.

Rollout or rollback impact
Rollout is fail-closed: collection may continue, but market_tape.v1 remains ineligible for replay-safe research selection. Rollback would reintroduce the false-safe empty-spool inference and the failed CI lane, so do not roll back; follow with a separately reviewed continuity-promotion PR.

[coderabbitai]

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 23 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 452794e3-8d00-4a2a-a88e-628df0b60ff5

📥 Commits

Reviewing files that changed from the base of the PR and between 6f79de1 and 22761d6.

📒 Files selected for processing (1)

• rust_hft/tools/collector/src/bin/binance-lob-archiver.rs

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/binance-market-tape-fail-closed

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}