Coordinate reusable Campaign execution, failures and recovery - #1185
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
proerror77
force-pushed
the
codex/ridge-h1-admission-20260914
branch
from
September 14, 2026 09:50
3ef13fc to
71ccc21
Compare
proerror77
force-pushed
the
codex/campaign-workflow-loop-20260914
branch
from
September 14, 2026 09:51
7c48b2f to
21c4171
Compare
proerror77
changed the base branch from
codex/ridge-h1-admission-20260914
to
main
September 14, 2026 10:08
proerror77
force-pushed
the
codex/campaign-workflow-loop-20260914
branch
from
September 14, 2026 10:10
21c4171 to
d5530ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
A research study required manual handoffs between preparation, signing, dispatch and ACK readback, and failures could lose the operation identity or restart completed work. Add a native ACK-only
campaign-workflowcoordinator over the existing canonical controller. A frozen plan can include multiple input groups; all groups share one preregistered comparison bound while each member keeps its own trial reservation.The coordinator skips validated completed members, resumes incomplete stages, rebuilds missing summaries from terminal evidence and retains the original deadline. Authenticated dispatch status binds Job UID, request and accounting state. The controller now waits for either Job success or failure, rejects identity drift and preserves failed request/submission evidence. Unknown/failed/deadline states are retained and exit nonzero; ordinary negative research results complete their member and continue the comparison.
MLP workflows require explicit gradient/loss/convergence and update-budget controls. Ridge-only workflows do not instantiate unrelated models or require MLP settings. This change composes the preparation, training-stop and holding contracts; signed grants, the platform signer, holdout boundaries and native settlement remain authoritative.
The Ridge-only and holding changes #1184 and #1183 are merged. The workflow accepts established immutable input receipts and approved controls; it does not mint its own authority or claim a real study has run.
Issue relationship
Closes #1179
Validation
Runtime impact and rollback
Merge may publish the existing runner/controller image families. The coordinator Job example requires exact source, resources, control and deadline from the approved study. No ACK resource was created and no real H1 experiment was started by this implementation. Revert the source/image and retain immutable native results and ledger evidence; do not reset prior experiment budgets.