Skip to content

Coordinate reusable Campaign execution, failures and recovery - #1185

Merged
proerror77 merged 4 commits into
mainfrom
codex/campaign-workflow-loop-20260914
Sep 14, 2026
Merged

proerror77 merged 4 commits into
mainfrom
codex/campaign-workflow-loop-20260914

Conversation

@proerror77

@proerror77 proerror77 commented Sep 14, 2026

Copy link
Copy Markdown
Owner

Change

A research study required manual handoffs between preparation, signing, dispatch and ACK readback, and failures could lose the operation identity or restart completed work. Add a native ACK-only campaign-workflow coordinator over the existing canonical controller. A frozen plan can include multiple input groups; all groups share one preregistered comparison bound while each member keeps its own trial reservation.

The coordinator skips validated completed members, resumes incomplete stages, rebuilds missing summaries from terminal evidence and retains the original deadline. Authenticated dispatch status binds Job UID, request and accounting state. The controller now waits for either Job success or failure, rejects identity drift and preserves failed request/submission evidence. Unknown/failed/deadline states are retained and exit nonzero; ordinary negative research results complete their member and continue the comparison.

MLP workflows require explicit gradient/loss/convergence and update-budget controls. Ridge-only workflows do not instantiate unrelated models or require MLP settings. This change composes the preparation, training-stop and holding contracts; signed grants, the platform signer, holdout boundaries and native settlement remain authoritative.

The Ridge-only and holding changes #1184 and #1183 are merged. The workflow accepts established immutable input receipts and approved controls; it does not mint its own authority or claim a real study has run.

Issue relationship

Closes #1179

Validation

  • Nine native workflow/guard regressions cover multiple input groups, budget planning before bulk reads, partial recovery, completed-summary recovery, expired readback-only behavior, source drift and retained failures.
  • Authenticated dispatch-status identity/accounting test and canonical controller success/failure/timeout/UID recovery cases.
  • Scoped Clippy, controller ShellCheck, YAML parsing and diff whitespace checks.

Runtime impact and rollback

Merge may publish the existing runner/controller image families. The coordinator Job example requires exact source, resources, control and deadline from the approved study. No ACK resource was created and no real H1 experiment was started by this implementation. Revert the source/image and retain immutable native results and ledger evidence; do not reset prior experiment budgets.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: a59c5019-274d-4698-bc8c-0763fc86c088


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-14T09:44:17.220928Z 7c48b2f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@proerror77
proerror77 force-pushed the codex/ridge-h1-admission-20260914 branch from 3ef13fc to 71ccc21 Compare September 14, 2026 09:50
@proerror77
proerror77 force-pushed the codex/campaign-workflow-loop-20260914 branch from 7c48b2f to 21c4171 Compare September 14, 2026 09:51
@proerror77
proerror77 changed the base branch from codex/ridge-h1-admission-20260914 to main September 14, 2026 10:08
@proerror77
proerror77 force-pushed the codex/campaign-workflow-loop-20260914 branch from 21c4171 to d5530ab Compare September 14, 2026 10:10
Comment thread rust_hft/alpha-harness/app/src/mission_campaign/workflow.rs Fixed
@proerror77
proerror77 merged commit eaf1464 into main Sep 14, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Complete reusable Campaign execution, training stops and failure recovery

2 participants