Skip to content

fix(polymarket): bound shadow parity memory - #119

Merged
proerror77 merged 1 commit into
mainfrom
codex/polymarket-parity-bounded-memory
Jul 17, 2026
Merged

proerror77 merged 1 commit into
mainfrom
codex/polymarket-parity-bounded-memory

Conversation

@proerror77

Copy link
Copy Markdown
Owner

Change contract

Stream and project shadow-parity tape rows so a large legacy spool cannot be fully materialized in memory, while preserving per-row integrity, stable-file, and parity-window semantics.

Acceptance evidence

  • Regression: 2,000 repeated out-of-projection metadata rows for a traded market retain fewer than 64 rows.
  • Counterexamples: out-of-window sequence corruption and malformed trade metadata context still fail closed.
  • Independent Spec review: no remaining blocker.
  • Independent Standards review: pass; one non-blocking LOW duplication smell.

Out of scope

  • Collector cutover, ECS writes, production gate execution, or health declaration.
  • Polymarket evidence consumer/compiler changes.
  • Binance producer Clippy fixes from current main.

Dependency or merge order

None. This is one reference-gate verifier behavior contract.

Focused validation

  • cargo fmt --package hft-collector -- --check
  • cargo clippy -p hft-collector --lib --bin polymarket-raw-ops --locked -- -D warnings
  • cargo test -p hft-collector --locked — 159 passed, 2 ignored; all binary tests passed.
  • cargo test -p hft-collector polymarket_parity::tests:: -- --nocapture — 22 passed.
  • git diff --check origin/main...HEAD

Full --all-targets Clippy currently stops on two pre-existing needless_borrow findings in binance-lob-archiver.rs on main; this PR does not touch that file.

Rollout/rollback impact

After merge, build a new immutable recovery candidate and rerun the full shadow gate before any cutover. Rollback is reverting this commit; no storage format or production state changes occur on merge.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 20 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 239407af-2520-4cc0-9797-9924bf1e6821

📥 Commits

Reviewing files that changed from the base of the PR and between 843de0a and d27a698.

📒 Files selected for processing (1)
  • rust_hft/tools/collector/src/polymarket_parity.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/polymarket-parity-bounded-memory

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Stream and window parity rows so large legacy tapes are validated without retaining every decoded JSON value.
@proerror77
proerror77 force-pushed the codex/polymarket-parity-bounded-memory branch from 514c376 to d27a698 Compare July 17, 2026 23:42
@proerror77
proerror77 merged commit 44b554b into main Jul 17, 2026
17 checks passed
@proerror77
proerror77 deleted the codex/polymarket-parity-bounded-memory branch July 17, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant