fix(data): reject non-positive replayed levels - #130
Conversation
|
Warning Review limit reached
Next review available in: 27 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8754a37 to
3c90f69
Compare
|
@coderabbitai review |
✅ Action performedReview finished.
|
Change contract
Reject a Binance market-tape Verified handle when any final replayed bid or ask level has a non-positive price or quantity.
Out of scope
Dependency / merge order
None. This PR was originally stacked on #129; after #129 merged it was retargeted to
main, updated, and revalidated at exact headcf0c3ac4152936a6a1b5a7b3aeef34ffecdb78f4.Focused validation
non_positive_replayed_book_levels_never_return_a_verified_handle; the old verifier incorrectly returned a verified handle with a zero price or negative quantity in the final ask.cf0c3ac4152936a6a1b5a7b3aeef34ffecdb78f4.Rollout / rollback impact
Verifier-only fail-closed tightening. No runtime service changes. Rollback is reverting this PR; artifacts with non-positive final levels remain rejected while active.