data: expose verified Binance LOB source clocks - #135
Conversation
|
Warning Review limit reached
Next review available in: 26 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Change contract
Preserve one read-only source/receive clock observation for every depth diff that already passed the Binance market-tape seal, schema, source-clock, sequence, and replay verifiers, so downstream audit and freshness logic need not fall back to receive time.
Out of scope
Snapshot projection, audit generation, replay-enum changes, checkpoint clock invention, artifact acquisition, collector behavior, and live execution.
Dependency or merge order
Base: main. Merge before the PR #133 review fix that consumes these verified clocks for LOB freshness.
Focused validation
GitHub Linux run 29645574913 passed cloud rustfmt, the complete hft-data Binance artifact test target, focused Clippy with warnings denied, and focused cargo check. Counterexamples prove missing and governed-limit-violating depth source clocks never return a verified handle; the positive test proves two verified diffs produce exactly two immutable clock projections. Scope: 1 file, 64 lines.
Rollout or rollback impact
No collector or runtime rollout. This only adds a private-field-backed read-only projection to an existing verified handle. Rollback is a single PR revert; existing consumers remain source compatible.