ci(prediction): scope rustfmt to nested workspace members - #138
Conversation
📝 WalkthroughWalkthroughThe Rust formatting CI job now discovers workspace member packages with ChangesRust formatting CI
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69028e0d7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
69028e0 to
2e40100
Compare
Change contract
Ensure the prediction-market Rust formatting gate checks every explicit member of the nested prediction workspace without traversing path dependencies owned by the outer
rust_hftworkspace.Out of scope
rust_hftworkspace crates.Dependency or merge order
None. Merge this focused CI prerequisite before PR #137 so that #137 can retain its cross-workspace typed dependency without absorbing unrelated formatting debt.
Focused validation
git diff --checkcargo fmt --allcrossed into 23 outer-workspace files and failed on pre-existing formatting differences.Rollout / rollback impact
CI-only. Rollout changes package selection for the Prediction Markets
Rust formattingjob from recursive--alltraversal to the exact Cargo metadataworkspace_membersset. Roll back by reverting this PR; no runtime or data migration is involved, and live execution remains disabled.