Skip to content

ci(prediction): scope rustfmt to nested workspace members - #138

Merged
proerror77 merged 1 commit into
mainfrom
codex/prediction-workspace-format-scope
Jul 18, 2026
Merged

proerror77 merged 1 commit into
mainfrom
codex/prediction-workspace-format-scope

Conversation

@proerror77

@proerror77 proerror77 commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Change contract

Ensure the prediction-market Rust formatting gate checks every explicit member of the nested prediction workspace without traversing path dependencies owned by the outer rust_hft workspace.

Out of scope

  • Formatting or otherwise changing the outer rust_hft workspace crates.
  • Changing projection, verifier, research, runtime, deployment, or live-execution behavior.
  • Relaxing formatting for any explicit prediction-workspace member.

Dependency or merge order

None. Merge this focused CI prerequisite before PR #137 so that #137 can retain its cross-workspace typed dependency without absorbing unrelated formatting debt.

Focused validation

  • git diff --check
  • Counterexample run 29651166655: cargo fmt --all crossed into 23 outer-workspace files and failed on pre-existing formatting differences.
  • Temporary Linux proof run 29651421612: explicit-member formatting, verified Binance projection counterexamples, policy identity counterexamples, focused clippy, and package check all passed.
  • Exact-head PR runs: Monorepo CI 29651857825, Prediction Markets CI 29651857828, and Security & Quality 29651857835 all passed.
  • Exact-head two-axis review: Standards 0 findings; Spec 0 findings.

Rollout / rollback impact

CI-only. Rollout changes package selection for the Prediction Markets Rust formatting job from recursive --all traversal to the exact Cargo metadata workspace_members set. Roll back by reverting this PR; no runtime or data migration is involved, and live execution remains disabled.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Rust formatting CI job now discovers workspace member packages with cargo metadata, validates that the list is non-empty, and runs the pinned Cargo formatter separately for each package.

Changes

Rust formatting CI

Layer / File(s) Summary
Dynamic package formatting check
.github/workflows/ploy-ci.yml
The rust-format job replaces the workspace-wide cargo fmt --all check with dynamically generated --package arguments and fails when no packages are detected.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the CI change to scope rustfmt to nested workspace members.
Description check ✅ Passed The description is mostly complete and covers the required sections, with only the explicit Scope exception placeholder omitted.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/prediction-workspace-format-scope

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 69028e0d7f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ploy-ci.yml Outdated
@proerror77
proerror77 force-pushed the codex/prediction-workspace-format-scope branch from 69028e0 to 2e40100 Compare July 18, 2026 16:23
@proerror77
proerror77 merged commit 96d29ce into main Jul 18, 2026
32 checks passed
@proerror77
proerror77 deleted the codex/prediction-workspace-format-scope branch July 19, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant