feat(research): report immutable prediction job status - #249
Conversation
|
Warning Review limit reached
Next review available in: 26 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 704e0165ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if evidence.lane != "prediction_market" | ||
| || evidence.mission_id != mission_id | ||
| || normalized_sha256("evidence mission", &evidence.mission_sha256)? != mission_sha256 | ||
| || normalized_sha256("evidence snapshot", &evidence.snapshot_archive_sha256)? | ||
| != snapshot_sha256 |
There was a problem hiding this comment.
When a resumed or repeated attempt uses the same mission ID/SHA and snapshot SHA, its evidence is indistinguishable here from evidence produced by the prior Job, so supplying the prior attempt's file sets both research milestones to true even if the requested Job never started. The immutable Job annotations already distinguish attempts through the attempt/result identity, but none of that identity is present in or checked against StatusEvidence; require evidence bound to the attempt, result identity, or Job UID before advancing these per-Job milestones.
AGENTS.md reference: AGENTS.md:L50-L54
Useful? React with 👍 / 👎.
Parent: #240
Closes #246
Change contract
Report read-only status for one exact immutable prediction-market research Job by explicit Kubernetes context, namespace, and Job name. Derive submitted, scheduled, image-ready, and completed from typed Job and controller-UID-bound Pod readback; only report snapshot-ready and evaluator-started when optional execution evidence matches the Job mission and snapshot annotations.
Out of scope
Dependency or merge order
Depends on #242 / #247, already merged. No remaining merge dependency. The cloud warm-worker benchmark in #243 may consume this read-only status contract after merge.
Focused validation
cargo clippy -p alpha-harness -- -D warningsgit diff --checkRollout / rollback impact
Rollout adds a read-only CLI subcommand that uses only Kubernetes
getoperations and performs no runtime mutation. Rollback is a single-PR revert; existing render and submit behavior is unchanged.