CI: package USD-M reference collector release - #257
Conversation
|
Warning Review limit reached
Next review available in: 26 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8e5234d22
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| docker cp "$container_id:/usr/local/bin/binance-usdm-reference-collector" artifact/binance-usdm-reference-collector | ||
| chmod 0755 artifact/binance-lob-archiver | ||
| chmod 0755 artifact/polymarket-raw-ops | ||
| chmod 0755 artifact/binance-usdm-reference-collector |
There was a problem hiding this comment.
When this bundle is downloaded through actions/upload-artifact@v4, the new collector is restored with mode 0644 because the action does not retain POSIX file permissions, so this chmod does not actually deliver the executable bare-metal artifact promised by the change contract. The action's permission-loss documentation recommends archiving executable files before upload; package the binary in a tar archive or ensure the verified installation path explicitly restores mode 0755.
Useful? React with 👍 / 👎.
Change contract
Publish
binance-usdm-reference-collectoras an executable Linux image/bare-metal artifact with candidate SHA-256 and source-bound release metadata.Part of #222. This PR does not close the issue.
Out of scope
Dependency or merge order
Depends on merged PR #255. Merge before the shadow service/gate control bundle.
Focused validation
bash deployment/aliyun/test-binance-usdm-reference-release-contract.shbash -n deployment/aliyun/test-binance-usdm-reference-release-contract.shcargo check --manifest-path rust_hft/Cargo.toml -p hft-collector --bin binance-usdm-reference-collectorgit diff --checkRollout / rollback impact
Rollout: CI artifacts gain one checksummed binary and release JSON; no host is changed. Rollback: revert this PR without affecting the running collectors or merged runtime code.