Skip to content

fix(deployment): tolerate one health sampling interval (#224) - #277

Merged
proerror77 merged 1 commit into
mainfrom
codex/cex-l2-health-jitter-224
Jul 23, 2026
Merged

proerror77 merged 1 commit into
mainfrom
codex/cex-l2-health-jitter-224

Conversation

@proerror77

Copy link
Copy Markdown
Owner

Change contract

Allow the CEX L2 shadow gate one additional 30-second polling interval for a health timestamp that advances after synchronized segment rotation, while still failing closed when either Spot or USD-M health is frozen beyond 120 seconds.

Acceptance evidence

  • Live gate invocation t-jpn6rsu25tptmgw ran both isolated shadow collectors without restarts or sequence gaps and failed at the former 90-second freshness boundary while USD-M finalized a valid 168.6 MB rotation.
  • deployment/aliyun/test-rust-lob-control-plane.sh passes.
  • Targeted counterexamples cover both Spot and USD-M: an advancing 91-second sample passes and a 121-second freeze fails.
  • bash -n, shellcheck, and git diff --check pass.
  • Read-only spec and standards reviews pass after the runbook and dual-market boundary tests were synchronized.

Out of scope

Dependency / merge order

None. This is the focused #224 deployment-gate correction discovered by the isolated production shadow run.

Focused validation

bash -n deployment/aliyun/host-rust-lob-shadow-gate.sh deployment/aliyun/test-rust-lob-control-plane.sh
shellcheck deployment/aliyun/host-rust-lob-shadow-gate.sh deployment/aliyun/test-rust-lob-control-plane.sh
deployment/aliyun/test-rust-lob-control-plane.sh
git diff --check

Rollout / rollback impact

After merge, rebuild/reinstall the immutable isolated candidate bundle and rerun the full one-hour #224 shadow gate before any cutover. Rollback is restoring the 90-second host/policy threshold; production remains untouched unless the full gate and canonical OSS readback pass.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 11 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 27cebac3-635c-42fd-a874-ab65ef7e4468

📥 Commits

Reviewing files that changed from the base of the PR and between a5c2500 and aa11497.

📒 Files selected for processing (4)
  • deployment/aliyun/README.md
  • deployment/aliyun/host-rust-lob-shadow-gate.sh
  • deployment/aliyun/rust-lob-shadow-gate-policy.jq
  • deployment/aliyun/test-rust-lob-control-plane.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/cex-l2-health-jitter-224

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proerror77

Copy link
Copy Markdown
Owner Author

CI triage for the single failing check:

  • PR run 30025048462, job 89267251624, passed Rust collector control-plane contracts before failing in the unrelated test-trading-ecs-host-contract.sh invocation.
  • Current main run 30023627096, job 89262383734, fails at the same invocation.
  • Root cause is existing baseline drift: .github/workflows/acr-publish.yml now contains three pinned actions/upload-artifact uses after the research-runner artifact was added, while deployment/aliyun/test-trading-ecs-host-contract.sh:1206-1208 still asserts exactly two.
  • This PR does not touch either file. All other checks passed, including Rust fast lane, Clippy, security, production image contract, and the Polymarket evidence image.

Per the one-behavior/one-rollout guardrail, that baseline CI repair is not being mixed into #224.

@proerror77
proerror77 merged commit 0845694 into main Jul 23, 2026
17 of 18 checks passed
@proerror77
proerror77 deleted the codex/cex-l2-health-jitter-224 branch July 24, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant