fix(polymarket): admit explicit failure disclosure - #285
Conversation
|
Warning Review limit reached
Next review available in: 13 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
CI follow-up: the first run failed only the fail-closed checked-in policy-pin test because artifact.rs is an input to prediction_policy_sources(). I refreshed the BTC and SOL example mission search_policy_snapshot_id values to the computed sha256:830987ac67746600bc2fb3b39fdab6442dfdc9a3b3cd43192f780a6e92cfce84. This is mechanical provenance required by the verifier change, not new research behavior. Focused reproduction now passes: cargo +1.91 test --locked -p ploy-research checked_in_btc_and_sol_templates_pin_current_brief_and_rust_policy --lib -- --nocapture |
Change contract
Allow only explicit-market monday.polymarket.evidence_artifact.v3 manifests with V2 validated inputs to disclose quote_collection_failure in the authenticated market event-type counts. Legacy V1 and non-explicit V2 inputs remain fail-closed.
Out of scope
Recovery/completeness inference, importer/compiler recovery policy (#283), collector/WebSocket behavior, evidence schema changes, snapshot/evaluator/MCTS logic, acquisition, deployment, and execution.
Dependency or merge order
This verifier-only prerequisite merges before #283. Rebase #283 onto main after this PR merges.
Focused validation
The targeted test proves explicit V3 acceptance, legacy V1 rejection, non-explicit V2 rejection, and explicit V3 rejection of an unknown market event type. Full package result: 56 passed, 0 failed.
A separate PRD is unnecessary because #284 defines one small verifier behavior and its fail-closed counterexamples; implementation followed the focused TDD path.
Rollout or rollback impact
Verifier recognition only; no deployment or artifact mutation. Reverting this PR restores rejection of evidence whose input identity discloses quote collection failures.
Closes #284