fix(polymarket): preserve exact manifest float round trips - #294
Conversation
|
Warning Review limit reached
Next review available in: 39 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Change contract
Ensure hft-collector parses serialized floating-point manifest values through serde_json round-trip precision so exact producer-versus-bound-FD equality remains fail-closed without accepting an epsilon.
A PRD is unnecessary because issue #292 defines one dependency-feature behavior and one production-derived counterexample; implementation followed Matt TDD.
Acceptance evidence
0.9340463458110517produced0.9340463458110516, while1048 / 1122produced0.9340463458110517.serde_json/float_roundtripfor hft-collector.Valueequality and the quality formula are unchanged; no epsilon is accepted.cargo test -p hft-collector: 211 passed, 2 ignored; all binary suites passed.cargo clippy -p hft-collector --all-targets --no-deps -- -D warnings: passed.git diff --check: passed.polymarket-raw-ops.rsandpolymarket_raw.rs; this PR does not absorb it.Out of scope
Approximate float equality; changing manifest schema or quality formula; unrelated formatting cleanup; collector deployment; data rewrapping; snapshot/evaluator logic.
Dependency / merge order
Depends only on merged #291 diagnostics. Merge this PR, publish one exact-main compiler image, then rerun the unchanged #270 triplet.
Focused validation
Production-derived 1-ULP counterexample, full hft-collector tests, strict Clippy, changed-file formatting, and two-axis code review.
Rollout / rollback impact
Dependency-feature-only parsing correction inside hft-collector. Rollback restores the false rejection; strict accepted-data semantics otherwise remain unchanged.
Closes #292