Skip to content

test(deploy): sync artifact upload count - #307

Merged
proerror77 merged 1 commit into
mainfrom
codex/ci-upload-artifact-contract-count
Jul 24, 2026
Merged

proerror77 merged 1 commit into
mainfrom
codex/ci-upload-artifact-contract-count

Conversation

@proerror77

Copy link
Copy Markdown
Owner

Change contract

Update the trading ECS host-contract test to recognize the third, already-present SHA-pinned actions/upload-artifact use for research runner binaries.

Out of scope

Workflow behavior, collector deployment, runtime policy, production cutover, and issue #224 data gates.

Dependency or merge order

Merge before rerunning #306 against current main; #306 is otherwise blocked by this pre-existing main CI contract drift.

Focused validation

  • Red: exact count check reported actual=3 expected=2.
  • Green: exact count check reports actual=3 expected=3.
  • Green: bash deployment/aliyun/test-trading-ecs-host-contract.sh
  • Green: shellcheck deployment/aliyun/test-trading-ecs-host-contract.sh
  • Green: git diff --check
  • Linux CI evidence: Monorepo CI run 30056112633 failed twice after all collector control-plane tests passed, at the stale host-contract count assertion.

Rollout / rollback impact

None. Test-only expectation sync; revert restores the stale count and makes current main fail its Linux contract job.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 48 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f66004a4-c4e2-442a-8410-24b077913fd1

📥 Commits

Reviewing files that changed from the base of the PR and between 3f28a39 and ca6799f.

📒 Files selected for processing (1)
  • deployment/aliyun/test-trading-ecs-host-contract.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/ci-upload-artifact-contract-count

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proerror77
proerror77 merged commit 46e526d into main Jul 24, 2026
18 checks passed
@proerror77
proerror77 deleted the codex/ci-upload-artifact-contract-count branch July 24, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant