Skip to content

fix(collector): acknowledge buffered proof rotations - #366

Merged
proerror77 merged 2 commits into
mainfrom
codex/collector-subscription-proof-rotation-224
Jul 26, 2026
Merged

proerror77 merged 2 commits into
mainfrom
codex/collector-subscription-proof-rotation-224

Conversation

@proerror77

@proerror77 proerror77 commented Jul 26, 2026

Copy link
Copy Markdown
Owner

Change contract

When a WebSocket subscription proof has buffered market frames, a rotation pause emits its RotationBarrier, abandons those unverified pre-boundary frames after resume, and reconnects before admitting any market data into the new segment.

PRD

Not required; this is a small, already-specified livelock and segment-boundary correction for issue #224, implemented directly with TDD.

Out of scope

  • Shadow-gate verifier memory or trust-anchor handling
  • Cloud Assistant Terminated cancellation polling/cleanup behavior
  • Snapshot, cohort, evaluator, or research logic
  • Production candidate installation, gate execution, or cutover

Dependency / merge order

Depends on merged PR #359. Based on main at a9f2f4568e64076dad11a624d201f7086cd3c42b; merge before building the replacement collector candidate.

Focused validation

  • Livelock red proof: the old code timed out waiting for RotationBarrier when proof frames were buffered.
  • Segment-boundary red proof: the first fix emitted StreamReconnected plus the stale buffered trade after resume instead of abandoning it.
  • Green: cargo test -p hft-collector --bin binance-lob-archiver buffered_reconnect_proof -- --nocapture (2 passed).
  • cargo test -p hft-collector --bin binance-lob-archiver -- --nocapture (63 passed).
  • cargo clippy -p hft-collector --bin binance-lob-archiver -- -D warnings.
  • git diff --check.
  • Workspace/package-wide cargo fmt --check is baseline-red on unrelated existing files and pre-existing lines in this collector; this PR adds no whitespace errors.

Rollout / rollback impact

No production state changes in this PR. After merge, build and install a new inactive candidate, rerun the formal shadow gate, and cut over only with immutable passing evidence. Roll back by retaining the current production release and previous inactive candidate.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 15 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8623bae2-3f3d-47c7-a46d-b5ac97f85d06

📥 Commits

Reviewing files that changed from the base of the PR and between a9f2f45 and acebaee.

📒 Files selected for processing (1)
  • rust_hft/tools/collector/src/bin/binance-lob-archiver.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/collector-subscription-proof-rotation-224

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 988a0e1d23

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rust_hft/tools/collector/src/bin/binance-lob-archiver.rs
@proerror77
proerror77 merged commit 15f266a into main Jul 26, 2026
40 checks passed
@proerror77
proerror77 deleted the codex/collector-subscription-proof-rotation-224 branch July 26, 2026 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant