fix(collector): acknowledge buffered proof rotations - #366
Conversation
|
Warning Review limit reached
Next review available in: 15 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 988a0e1d23
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Change contract
When a WebSocket subscription proof has buffered market frames, a rotation pause emits its
RotationBarrier, abandons those unverified pre-boundary frames after resume, and reconnects before admitting any market data into the new segment.PRD
Not required; this is a small, already-specified livelock and segment-boundary correction for issue #224, implemented directly with TDD.
Out of scope
Terminatedcancellation polling/cleanup behaviorDependency / merge order
Depends on merged PR #359. Based on
mainata9f2f4568e64076dad11a624d201f7086cd3c42b; merge before building the replacement collector candidate.Focused validation
RotationBarrierwhen proof frames were buffered.StreamReconnectedplus the stale buffered trade after resume instead of abandoning it.cargo test -p hft-collector --bin binance-lob-archiver buffered_reconnect_proof -- --nocapture(2 passed).cargo test -p hft-collector --bin binance-lob-archiver -- --nocapture(63 passed).cargo clippy -p hft-collector --bin binance-lob-archiver -- -D warnings.git diff --check.cargo fmt --checkis baseline-red on unrelated existing files and pre-existing lines in this collector; this PR adds no whitespace errors.Rollout / rollback impact
No production state changes in this PR. After merge, build and install a new inactive candidate, rerun the formal shadow gate, and cut over only with immutable passing evidence. Roll back by retaining the current production release and previous inactive candidate.