fix(collector): separate Polymarket settlement time from parity context - #386
Conversation
|
Warning Review limit reached
Next review available in: 20 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Change contract
Make the Polymarket Rust shadow parity verifier validate raw Data API trade identity, exact cross-collector values, and market association without treating Polygon settlement time as research-window execution time. Preserve source and receipt timestamps and every existing fail-closed parity surface.
Closes #385. Parent deployment issue: #326.
Out of scope
Collector ingestion behavior, snapshot or research logic, #235 temporal-completeness/admission policy, production cutover, historical repair, and timestamp grace periods.
Dependency / merge order
Independent follow-up to merged #380. No stacked PR dependency; merge this before building the next immutable #326 Rust candidate.
Focused validation
polymarket-raw-ops verify-shadow-parityfixture failed withbyte/field/dedupe/settlement/rotation parity failedfor a sharedendDate+19ssettlement timestamp.bash deployment/aliyun/test-polymarket-raw-ops-control-plane.shcargo test -p hft-collector --no-default-features --locked(221 passed, 2 ignored; all binary tests passed)cargo clippy -p hft-collector --all-targets --locked -- -D warningsrustfmt --edition 2021 --check tools/collector/src/polymarket_parity.rsThe public fixture asserts both lanes retain two trades, shared values match, and the post-end trade preserves
trade_ts_unix=319, nested source timestamp319, andreceived_at=321.Rollout / rollback impact
No production mutation in this PR. After merge, build a new exact-main immutable candidate and run a fresh governed shadow Gate before cutover. Rollback is reverting this verifier-only commit; production remains on the Python baseline until Gate success.