Keep Polymarket upload stdout machine-readable - #393
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe OSS command runner now discards child stdout, preserving the uploader’s machine-readable output. A regression test confirms progress text is not written to a configured output target. ChangesPolymarket uploader output
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change contract
Suppress child
ossutilstdout in the shared Polymarket OSS runner sopolymarket-raw-ops uploademits exactly one machine-readable JSON document while preserving stderr and fail-closed exit handling.Why no PRD
This is a small, already-specified behavior repair from #392 with one public boundary and one regression seam; it was implemented directly with a red-green TDD cycle.
Out of scope
Dependency / merge order
main38133934361cc26dcc222cdd67493d11b804a45cafter fix(collector): bind Polymarket binary to source revision #391.Focused validation
cargo test -p hft-collector oss_runner_keeps_machine_readable_stdout_clean -- --nocapturefailed withleft: ossutil progress,right: [].rustfmt --edition 2021 --check tools/collector/src/polymarket_upload.rscargo test -p hft-collector(all package tests pass; only pre-existing ignored network/subprocess targets remain ignored).cargo clippy -p hft-collector --all-targets -- -D warningscargo fmt --all -- --checkremains blocked by unrelated pre-existing formatting drift outside this PR; this PR does not touch those files.Rollout / rollback impact
After merge, build a new exact-main candidate and run a fresh 3600s + 601s Shadow Gate. Production stays on Python until immutable Gate evidence passes. Rollback is a one-commit revert; error stderr, non-zero exits, timeouts, and upload/readback integrity checks are unchanged.
Closes #392
Summary by CodeRabbit