Skip to content

fix(polymarket): block legacy uploader recorder rollout - #481

Closed
proerror77 wants to merge 1 commit into
mainfrom
codex/polymarket-recorder-uploader-admission-479
Closed

proerror77 wants to merge 1 commit into
mainfrom
codex/polymarket-recorder-uploader-admission-479

Conversation

@proerror77

Copy link
Copy Markdown
Owner

Refs #479

Change contract

Fail closed in Polymarket market-recorder deploy admission when the active market-tape uploader identity is still the legacy Python runtime instead of the Rust raw-ops uploader.

Out of scope

  • Changing the legacy Python uploader implementation.
  • Changing raw-ops formal Gate supervision or cutover sequencing.
  • Research/snapshot changes.

Dependency or merge order

  • Base: main @ a98f26d93ce8c40c05466713de7c43b251fbd671
  • Merge order: independent

Focused validation

  • bash deployment/aliyun/test-polymarket-market-recorder-release.sh
  • shellcheck deployment/aliyun/polymarket-market-recorder-deploy.sh deployment/aliyun/test-polymarket-market-recorder-release.sh
  • git diff --check
  • Red-capable proof embedded in test-polymarket-market-recorder-release.sh: legacy Python uploader makes both preflight and install fail, then exact Rust uploader identity makes the same path pass.

Rollout / rollback impact

  • Rollout: recorder deploys now refuse to mutate production until the market-tape uploader identity is the canonical Rust uploader unit with empty drop-ins and exact ExecStart.
  • Rollback: none for existing production state; this PR only tightens admission before mutation.

Why no PRD

This is a focused bug fix against Issue #479 with a single deploy-admission behavior change and a targeted counterexample test seam.

@proerror77
proerror77 force-pushed the codex/polymarket-recorder-uploader-admission-479 branch from 40fad88 to 2c94b50 Compare July 29, 2026 13:14
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: efa9219b-a6f1-4893-b642-a4778f7e58a1

📥 Commits

Reviewing files that changed from the base of the PR and between 3aae5dd and 2c94b50.

📒 Files selected for processing (2)
  • deployment/aliyun/polymarket-market-recorder-deploy.sh
  • deployment/aliyun/test-polymarket-market-recorder-release.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proerror77

Copy link
Copy Markdown
Owner Author

Closing as an intentionally abandoned contract. Requiring the production Rust market uploader before recorder admission creates a circular dependency with the parent #447 design, where recorder and raw-ops are separate rollout units and the uploader changes only after the supervised raw-ops Gate. Live evidence also shows the legacy uploader failure predates the recorder upgrade, so this guard would not repair the backlog. The correct path is #483 staging -> separate terminal-receipt admission -> exact artifact/preflight/Gate/cutover. The remote branch is intentionally retained; no cleanup deletion is performed.

@proerror77 proerror77 closed this Jul 29, 2026
@proerror77
proerror77 deleted the codex/polymarket-recorder-uploader-admission-479 branch August 13, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant