fix(polymarket): permit expedited 15-minute shadow Gate - #487
Conversation
|
Warning Review limit reached
Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe shadow gate observation window changes to 900 seconds. Legacy baseline health completion becomes optional, with the requirement recorded in gate evidence and enforced conditionally by the jq policy. Control-plane tests update fixtures, mutations, timing thresholds, runtime boundaries, and health-budget assertions. ChangesShadow gate policy
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant ShadowGate as Shadow gate
participant Evidence as Gate evidence
participant Policy as Gate policy
ShadowGate->>Evidence: Record 900-second duration and completion flag
Evidence->>Policy: Submit baseline health evidence
Policy-->>ShadowGate: Accept or reject admission
Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
monday/deployment/aliyun/polymarket-raw-ops-shadow-gate.sh
Lines 1462 to 1463 in 4aa8380
When the expedited gate ends before the legacy collector's documented 35–58 minute full-catalog cycle completes, this branch marks the legacy lane ready unconditionally even though the clean startup snapshot predates the parity window. The verifier in polymarket_parity.rs only requires nonempty legacy ID sets to be subsets of the Rust sets and explicitly permits unconstrained Rust-only IDs, so a partially written legacy cycle can satisfy parity after collecting only some markets; a same-PID post-start health publication containing API errors is ignored as well. This can authorize production using incomplete comparator evidence, so retain a completion/coverage proof for the selected cutoff or make parity require complete symmetric coverage before advancing.
AGENTS.md reference: AGENTS.md:L70-L74
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4aa8380 to
f7b8c65
Compare
Change contract
Permit an expedited Polymarket production Gate with a 900-second Rust observation plus the existing 601-second parity tail. For a legacy-Python baseline, the Gate requires a policy-clean atomic health publication before shadow startup and continuous service identity during the run, then records that a second full-catalog Python health publication was not required. The immutable evidence records
baseline_health_completion_required=falsefor this exception.Issue relationship
Refs #486
Acceptance evidence
bash deployment/aliyun/test-polymarket-raw-ops-control-plane.shgit diff --checkOut of scope
Uploader semantics, collector health policy, research/snapshot/#235, production installation, and production cutover.
Dependency / merge order
Base:
c1bf15833d0052edaf07d7c82d0d6977405b08ba(main). No PR dependency.Rollout / rollback impact
A future exact-source release must be rebuilt, signed, installed as a candidate, and pass real-segment preflight before the 1501-second Gate can run. The Gate remains fail-closed on Rust health, Rust/Python identity, real-segment parity, OSS readback, and immutable evidence. Reverting this PR restores the one-hour Gate policy; this PR does not alter production services.