fix(polymarket): keep cutover bounded while backlog drains - #518
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 52 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesMarket upload cutover
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@deployment/aliyun/test-polymarket-raw-ops-control-plane.sh`:
- Around line 4310-4320: Extend the test coverage around
verify_deferred_market_upload in test-polymarket-raw-ops-control-plane.sh with
mocked runtime counterexamples, not just grep-based source checks: assert
failure for stale invocation IDs, failed or inactive oneshot results, and a
mismatched /proc/<pid>/exe. Keep each scenario targeted and verify that
verify_deferred_market_upload returns failure.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: c8491612-1720-4685-9b9a-59015481a8ea
📒 Files selected for processing (2)
deployment/aliyun/polymarket-raw-ops-cutover.shdeployment/aliyun/test-polymarket-raw-ops-control-plane.sh
Change contract
Keep Polymarket production promotion bounded by starting the historical
market-tape backlog asynchronously after the immutable real-segment/Gate OSS
proof, while retaining exact Rust process, timer, reference-upload, and
fail-closed checks. Refs #517.
Issue relationship
Refs #517
Out of scope
Collector or uploader data semantics, historical spool deletion/rewriting,
research, snapshot/#235, evaluator/MCTS, CI restructuring, and production
mutation.
Dependency / merge order
Base is exact
main2407ebb64df61d616af579aa675d611a273e48a0.No stacked PR dependency. Runtime issue #517 remains open until live recovery
and cleanup evidence is recorded.
Focused validation
and terminal-success wait.
bash deployment/aliyun/test-polymarket-raw-ops-control-plane.shbash -n deployment/aliyun/polymarket-raw-ops-cutover.sh deployment/aliyun/test-polymarket-raw-ops-control-plane.shshellcheck deployment/aliyun/polymarket-raw-ops-cutover.sh deployment/aliyun/test-polymarket-raw-ops-control-plane.shgit diff --checkRollout / rollback impact
After Rust collector health and synchronous reference upload succeed, cutover
resets stale market-service failure state, starts a new market uploader job with
--no-block, and requires a new exact Rust Invocation/PID/exe (or fast terminalsuccess) within ten seconds. Both timers must be active, and market-service
failure is rechecked before evidence and success-marker publication. Historical
backlog continues under the timer. Existing immutable rollback snapshot and
official rollback command are unchanged.