ci(rust): backfill sccache-action pattern onto ploy-ci and acr-publish - #570
Conversation
|
Warning Review limit reached
Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e211896dd4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Replace the homegrown sccache setup (apt/cargo install plus actions/cache on ~/.cache/sccache, whose research-image primary key embedded github.sha and could never hit) with the #559/#566 pattern in every job that compiles Rust on the runner: - mozilla-actions/sccache-action@v0.0.10 with continue-on-error and a fallback step that unsets RUSTC_WRAPPER/SCCACHE_GHA_ENABLED - job env RUSTC_WRAPPER=sccache and SCCACHE_GHA_ENABLED=true - Swatinem/rust-cache keys dimensioned on rustc version, sccache version, and Cargo.lock - ${SCCACHE_PATH:-sccache} --show-stats || true evidence steps The acr-publish publish matrix compiles inside docker buildx, so the host-side wrapper does not apply there and that job is unchanged. No test semantics, job conditions, or gating changed. Refs #567
e211896 to
de614d5
Compare
Change contract
Backfill the #559/#566 sccache pattern onto the two remaining heavy lanes: 7 compile jobs in ploy-ci.yml (research-image-binaries, rust-control-plane, rust-runner-lean/full, rust-market-data, rust-research-heavy, integration-regressions) and research-runner-binaries in acr-publish.yml. Each gets sccache-action (continue-on-error + wrapper-disable fallback), dimensioned rust-cache keys (rustc + sccache + Cargo.lock), and a show-stats evidence step. The homegrown install +
~/.cache/sccache+ never-hitting${{ github.sha }}key segments are removed.Out of scope
Dependency / merge order
None. One cold run per lane expected after merge (new cache keys).
Focused validation
test-select-rust-ci-scope.shPASS (new per-job pins on all 7 ploy-ci jobs + negative pins on removed patterns)test-acr-publish-workflow.shPASSRollout / rollback impact
CI-only; a flaky sccache setup degrades to uncached builds (no red gate). Rollback = revert.
Issue relationship
Closes #567