Skip to content

chore: remove broken ccpm gitlink - #572

Closed
proerror77 wants to merge 1 commit into
mainfrom
codex/rm-ccpm-gitlink
Closed

proerror77 wants to merge 1 commit into
mainfrom
codex/rm-ccpm-gitlink

Conversation

@proerror77

Copy link
Copy Markdown
Owner

Change contract

Delete the ccpm tree entry: it is a gitlink with no .gitmodules registration (accidentally added in 33ecc78). Nothing references it.

Why now

It breaks actions/checkout whenever a job runs the submodule sshCommand cleanup path (git submodule foreach resolves submodule URLs and dies on this one). Observed in production failing the new market_recorder_contract job on #569; the pre-existing jobs only survive it by luck of their checkout configuration.

Out of scope

  • Evaluating whether ccpm tooling should be reintroduced properly (with .gitmodules)

Dependency / merge order

Merge before #569 (its checkout fix depends on this).

Focused validation

  • git ls-tree shows no remaining ccpm entry; no code references found repo-wide

Rollout / rollback impact

Hygiene only. Rollback = revert.

Issue relationship

None

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3c5f9b0b-7140-4421-a6c3-e0cf045a3200

📥 Commits

Reviewing files that changed from the base of the PR and between 4fa2477 and 7dd1f80.

📒 Files selected for processing (1)
  • ccpm

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proerror77
proerror77 enabled auto-merge (squash) August 1, 2026 08:26

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c9362acf0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ccpm
@@ -1 +0,0 @@
Subproject commit 9b1acb26dd59bc446ac7c5dcf6e34e9e878e568a

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove the remaining unregistered gitlink

When checkout reaches its submodule cleanup path, deleting only this entry does not unblock it: at the target commit, rust_hft/serena remains a mode-160000 gitlink while the tree contains no .gitmodules file. Git's help lists the relevant form as git submodule foreach [--recursive] <command>, and running it against this exact target still exits 128 with fatal: No url found for submodule path 'rust_hft/serena' in .gitmodules. Remove that accidental gitlink too or add a valid registration; otherwise the checkout failure this commit is intended to fix merely moves from ccpm to rust_hft/serena.

Useful? React with 👍 / 👎.

The ccpm entry is a gitlink with no .gitmodules registration (added
accidentally in 33ecc78). It breaks actions/checkout whenever a job
runs the submodule sshCommand cleanup path (observed failing the
market_recorder_contract job on #569). Nothing references it.
@proerror77
proerror77 force-pushed the codex/rm-ccpm-gitlink branch from 3c9362a to 7dd1f80 Compare August 1, 2026 08:31
@proerror77

Copy link
Copy Markdown
Owner Author

Superseded: the gitlink removal was cherry-picked into #569 (which carries it to main).

@proerror77 proerror77 closed this Aug 1, 2026
auto-merge was automatically disabled August 1, 2026 08:53

Pull request was closed

@proerror77
proerror77 deleted the codex/rm-ccpm-gitlink branch August 13, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant