chore: remove broken ccpm gitlink - #572
proerror77 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 5 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c9362acf0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1 +0,0 @@ | |||
| Subproject commit 9b1acb26dd59bc446ac7c5dcf6e34e9e878e568a | |||
There was a problem hiding this comment.
Remove the remaining unregistered gitlink
When checkout reaches its submodule cleanup path, deleting only this entry does not unblock it: at the target commit, rust_hft/serena remains a mode-160000 gitlink while the tree contains no .gitmodules file. Git's help lists the relevant form as git submodule foreach [--recursive] <command>, and running it against this exact target still exits 128 with fatal: No url found for submodule path 'rust_hft/serena' in .gitmodules. Remove that accidental gitlink too or add a valid registration; otherwise the checkout failure this commit is intended to fix merely moves from ccpm to rust_hft/serena.
Useful? React with 👍 / 👎.
3c9362a to
7dd1f80
Compare
|
Superseded: the gitlink removal was cherry-picked into #569 (which carries it to main). |
Change contract
Delete the
ccpmtree entry: it is a gitlink with no.gitmodulesregistration (accidentally added in 33ecc78). Nothing references it.Why now
It breaks
actions/checkoutwhenever a job runs the submodule sshCommand cleanup path (git submodule foreachresolves submodule URLs and dies on this one). Observed in production failing the newmarket_recorder_contractjob on #569; the pre-existing jobs only survive it by luck of their checkout configuration.Out of scope
Dependency / merge order
Merge before #569 (its checkout fix depends on this).
Focused validation
git ls-treeshows no remaining ccpm entry; no code references found repo-wideRollout / rollback impact
Hygiene only. Rollback = revert.
Issue relationship
None