fix(pm-parity): admit trade-completion records in shadow parity verification

[proerror77]

Change contract

Let verify-shadow-parity accept reference tapes containing polymarket_trade_collection_complete rows, so a Rust→Rust shadow gate can run. Refs #587.

The production Rust collector (since dc26acd) writes completion proofs for every finalized market; the parity KINDS allowlist only covered metadata/trades/settlements, so the first Rust→Rust gate died with invalid update kind. Completion proofs are per-lane polling bookkeeping emitted on independent schedules — admitted by the parser, excluded from the comparison window. Metadata/trade/settlement comparison semantics unchanged. Legacy→Rust gates never hit this because the legacy lane does not emit completion records.

Issue relationship

Refs #587

Out of scope

• Cross-lane comparison of completion proofs (needs schedule-tolerant semantics; follow-up if wanted).
• Gate preflight budget for tick-level segments (fix(pm-gate): real-market preflight budget too small for tick-level segments #586).

Dependencies and merge order

None.

Focused validation

• cargo test -p hft-collector polymarket_parity:: — 29 passed, 0 failed.
• Counterexample test: completion rows appended to both lanes still pass parity (trade_completion_rows_are_admitted_and_excluded_from_parity).

Rollout and rollback

• Rebuild the raw-ops candidate from the merged SHA, re-run the shadow gate, then cutover; parked market segments return to the spool afterward for the fixed uploader (fix(pm-upload): tolerate bounded per-token quote source-time jitter #585).
• Rollback = previous raw-ops release; production lane untouched until cutover.

Scope exception

None

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of Polymarket trade collection completion updates.
  • Completion records are now accepted without affecting parity comparison results.
  • Preserved existing handling for metadata, trades, and settlements.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8d280a34-56f9-4e76-8e94-731ea37f95e2

📥 Commits

Reviewing files that changed from the base of the PR and between 5522d15 and 411aa4c.

📒 Files selected for processing (1)

• rust_hft/tools/collector/src/polymarket_parity.rs

---

📝 Walkthrough

Walkthrough

The collector now accepts polymarket_trade_collection_complete tape updates. It admits these bookkeeping rows during parsing but excludes them from parity comparison data. A test validates completion records from both collector lanes.

Changes

Polymarket completion parity

Layer / File(s)	Summary
Completion record parsing rust_hft/tools/collector/src/polymarket_parity.rs	The collector accepts polymarket_trade_collection_complete updates and excludes completion rows from the parity comparison window.
Completion record parity test rust_hft/tools/collector/src/polymarket_parity.rs	The test adds completion records with different lane-specific condition IDs and verifies that parity passes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

• fix(pm-parity): admit trade-completion records in shadow parity verification #587 — Requests parity handling for polymarket_trade_collection_complete records.

Possibly related PRs

• proerror77/monday#48 — Updates related Polymarket parity tape-row handling.
• proerror77/monday#51 — Modifies the same collector logic for accepted tape records.
• proerror77/monday#152 — Relates to admitting completion records while excluding them from parity comparisons.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the primary change: admitting trade-completion records in Polymarket shadow parity verification.
Description check	✅ Passed	The description covers the change, issue relationship, scope, dependencies, validation, rollout, rollback, and scope exception.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/pm-parity-completion

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}