-
Notifications
You must be signed in to change notification settings - Fork 1
Simplify Monday agent guidance and add read-only audit Skills #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| --- | ||
| name: monday-delivery-status | ||
| description: Report Monday delivery truth as separate Code, CI, merge, release, runtime, and readback states with exact live identities. Use for status questions such as "现在卡在哪里", "是否完成", "能否上线", PR/CI triage, release checks, deployment checks, or any claim that work has shipped. | ||
| --- | ||
|
|
||
| # Monday Delivery Status | ||
|
|
||
| Produce a read-only status report. Never infer a later state from an earlier one. | ||
|
|
||
| ## Workflow | ||
|
|
||
| 1. Identify the requested branch, PR, release, service, and environment. If the user names only a local change, start from the current branch and `HEAD`. | ||
| 2. Read local branch, `HEAD`, worktree status, and upstream without changing files. | ||
| 3. Refresh live GitHub evidence. Read the PR head SHA, merge state, required checks, reviews, target branch, and latest relevant workflow or release artifact. | ||
| 4. Read deployment and runtime state only when the target and access path are known. Record the deployed image/SHA, configuration identity, health, and named controller if present. | ||
| 5. Read the final external artifact or service independently. Verify that its immutable identity and configuration match `Runtime`; otherwise mark `Runtime` or `Readback` `unknown`. A publish command or healthy process is not readback. | ||
| 6. Mark each state `passed`, `failed`, `pending`, `blocked`, or `unknown`. Use `unknown` when direct evidence is unavailable. | ||
|
|
||
| ## State contract | ||
|
|
||
| - **Code**: exact commit exists and focused local validation passed; any failed focused check makes this state `failed`. | ||
| - **CI**: required checks for that exact PR head finished successfully. | ||
| - **Merge**: GitHub reports the exact head merged into the intended base. | ||
| - **Release**: an artifact or image exists and its immutable identity matches the merged commit. | ||
| - **Runtime**: the intended environment runs that immutable identity with the intended configuration and passing health checks. | ||
| - **Readback**: an independent query observes the expected terminal output or service behavior from the same deployed immutable identity and configuration. | ||
|
|
||
| Do not collapse runner outages, code failures, mergeability, approval, deployment, or runtime health into one "CI failed" or "done" result. | ||
|
|
||
| ## Stop conditions | ||
|
|
||
| - Stop mutation entirely; this Skill never reruns CI, merges, deploys, restarts, or changes configuration. | ||
| - Stop and report `blocked` if branch or PR head moves during the audit. | ||
| - Report authentication, network, or permission gaps as `unknown`; do not reuse stale screenshots or old green runs. | ||
|
|
||
| ## Output | ||
|
|
||
| Return one row per state with: `State | Result | Exact identity | Direct evidence | Blocker/next check`. | ||
| End with one sentence naming the earliest incomplete state; that is the current blocker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| interface: | ||
| display_name: "Monday Delivery Status" | ||
| short_description: "Separate live delivery states with exact evidence" | ||
| default_prompt: "Use $monday-delivery-status to report the current delivery state of this Monday change." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| --- | ||
| name: monday-research-evidence-audit | ||
| description: Audit Monday research evidence from authenticated input through snapshot, Mission admission, evaluator output, immutable publication, and independent readback. Use when checking research E2E readiness or completion, ResearchSnapshot, evaluator/MCTS results, sealed holdout evidence, OSS artifacts, cohort completeness, or claims that a research run succeeded. | ||
| --- | ||
|
|
||
| # Monday Research Evidence Audit | ||
|
|
||
| Audit existing evidence only. Do not collect data, run evaluation, publish results, or touch production. | ||
|
|
||
| ## Workflow | ||
|
|
||
| 1. Name one research contract, venue/instrument, time window, and expected terminal artifact. | ||
| 2. Follow immutable identities through every stage: | ||
| - authenticated input manifest and source digest; | ||
| - venue admission or verifier receipt and ready-catalog identity when required; | ||
| - cohort/partition and `ResearchSnapshot` digest; | ||
| - admitted typed Mission, policy/configuration digest, and selected evaluator repository/binary/OCI identity; | ||
| - evaluator or MCTS run identity, receipt-bound runtime identity, terminal result, and sealed-holdout isolation evidence; | ||
| - immutable result bundle and checksum; | ||
| - independent OSS or artifact-store readback of the same bytes and checksum. | ||
| 3. At each boundary, compare both the referenced identity and the actual content. Record `passed`, `missing`, `mismatch`, `stale`, `unknown`, or `not applicable`. Use `unknown` for authentication, network, permission, or other observability gaps; reserve `missing` for verified absence. | ||
| 4. Check that fixtures, synthetic substitutes, unrelated collector health, CI success, and preparation logs are not being used as terminal research evidence. | ||
| 5. The overall result passes only when every required boundary passes for the same contract and window. | ||
|
|
||
| ## Safety boundaries | ||
|
|
||
| - Never fabricate missing history or completeness. Mark unreconstructable data `missing` and state the excluded window. | ||
| - Never use research authority to start collectors, alter deployment, submit orders, change risk limits, or enable Paper/Shadow/Live. | ||
| - Do not treat collector deployment, snapshot construction, evaluation, and publication as one rollout unit. | ||
| - Do not expose credentials or secret material; record only authenticated status and immutable public identities. | ||
|
|
||
| ## Stop conditions | ||
|
|
||
| Stop following a branch when an identity breaks or cannot be read back. Continue checking independent branches only if that helps locate multiple gaps; the terminal result remains incomplete. | ||
|
|
||
| ## Output | ||
|
|
||
| Return `Stage | Result | Expected identity | Observed identity | Evidence | Gap` for the seven stages above. | ||
| End with `Overall: passed` or `Overall: incomplete`, followed by the earliest broken boundary and the smallest read-only check needed next. | ||
4 changes: 4 additions & 0 deletions
4
.agents/skills/monday-research-evidence-audit/agents/openai.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| interface: | ||
| display_name: "Monday Research Evidence Audit" | ||
| short_description: "Audit the research chain without mutations" | ||
| default_prompt: "Use $monday-research-evidence-audit to audit this Monday research evidence chain." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| --- | ||
| name: monday-worktree-audit | ||
| description: Classify Monday Git worktrees as active, dirty, or Git-prunable without deleting or cleaning them. Use for worktree inventory, branch cleanup planning, disk-usage review, stale-worktree questions, ownership conflicts, or before any request to remove a worktree or branch. | ||
| --- | ||
|
|
||
| # Monday Worktree Audit | ||
|
|
||
| Produce a read-only inventory. Classification is not deletion authorization. | ||
|
|
||
| ## Workflow | ||
|
|
||
| 1. From the repository, run `.github/scripts/agent-worktree-preflight.sh report`. | ||
| 2. Read `git worktree list --porcelain` and preserve each exact path, branch or detached `HEAD`, and Git's `prunable` marker. | ||
|
proerror77 marked this conversation as resolved.
|
||
| 3. Enumerate local branches with `git for-each-ref refs/heads` and report branches not attached to any worktree separately. | ||
| 4. For every dirty entry, report changed and untracked paths without modifying them. | ||
| 5. For any cleanup candidate, additionally read its ownership record, exact `HEAD`, upstream/push state, open or closed PR state, merge state, and active-session use. | ||
| 6. Classify worktrees exactly once, using the preflight report as authoritative: | ||
| - `active`: registered, clean, and not Git-prunable; | ||
| - `dirty`: tracked or untracked changes exist; | ||
| - `prunable`: Git itself marks the administrative worktree record prunable. | ||
| Record ownership or session use only in `Owner/use`; it never changes `State`. | ||
| 7. Keep `cleanup-safe` separate from those three states. It requires explicit user authorization plus clean state, no unpushed work, resolved PR disposition, no active owner/session, and a recorded recovery identity. | ||
|
|
||
| ## Stop conditions | ||
|
|
||
| - Never run worktree removal, branch deletion, reset, clean, prune, or discard commands. | ||
| - If ownership, push state, PR disposition, or active use is unknown, keep the entry and mark cleanup safety `unknown`. | ||
| - A merged or newer PR never makes a nearby dirty worktree safe to remove. | ||
|
|
||
| ## Output | ||
|
|
||
| Return totals for `active`, `dirty`, and `prunable`, followed by: | ||
| `Path | Branch/HEAD | State | Dirty/unpushed | PR | Owner/use | Cleanup safety | Reason`. | ||
| Then list unattached branches as `Branch | HEAD | Upstream/unpushed | PR | Owner/use | Cleanup safety | Reason`. | ||
| List only evidence-backed cleanup candidates in a separate final section; do not recommend deletion without an exact authorized path list. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| interface: | ||
| display_name: "Monday Worktree Audit" | ||
| short_description: "Classify worktrees safely without cleanup" | ||
| default_prompt: "Use $monday-worktree-audit to classify the current Monday worktrees." |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.