Skip to content

runtime(research): package Spot replay materializer in runner - #692

Merged
proerror77 merged 2 commits into
mainfrom
codex/spot-admission-image-691
Aug 4, 2026
Merged

proerror77 merged 2 commits into
mainfrom
codex/spot-admission-image-691

Conversation

@proerror77

@proerror77 proerror77 commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Change contract

Add the existing binance-replay-parquet-materializer to every existing research-runner release and image contract surface: binary build/install, executable allowlist, exact release manifest/count, mode restore, Dockerfile packaging, CI/post-push probes, focused fixtures, and the Aliyun research operator inventory. Materializer behavior and dependencies remain unchanged.

Issue relationship

Refs #691

Out of scope

No materializer behavior change, dependency, ACK Job/Pod, Aliyun executor, source-byte access, verifier/materialization workload, research/backtest, production collector/ECS, ClickHouse adoption, PM, Paper, Shadow, Live, or order path.

Dependencies and merge order

None. This PR is based directly on exact origin/main@112d2b24fbb87d95a47534b785ec81131ef443af and is the independent image-contract unit before the #691 executor gate.

Focused validation

Remote CI must build the exact head, verify exactly seven executable release files with bound SHA-256 entries, restore executable modes, build the prebuilt image, and probe /usr/local/bin/binance-replay-parquet-materializer --help. No local Cargo, Docker, image, or data workload is used.

Rollout and rollback

No production rollout. Revert the single PR commit to remove the seventh research entrypoint; the separate immutable ACR publish and Aliyun executor remain gated on the merged source revision.

Scope exception

None.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 48 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 10e463bf-13fc-4319-ad0f-1fad07590f43

📥 Commits

Reviewing files that changed from the base of the PR and between a56ca01 and 77e4cd0.

📒 Files selected for processing (1)
  • .github/workflows/acr-publish.yml
📝 Walkthrough

Walkthrough

The research image now builds, packages, installs, and validates binance-replay-parquet-materializer as a seventh stable binary. Release scripts, CI workflows, contract tests, and documentation include the new entrypoint.

Changes

Research binary integration

Layer / File(s) Summary
Build, package, and install the research binary
.github/workflows/acr-publish.yml, .github/workflows/ploy-ci.yml, rust_hft/deployment/docker/Dockerfile.research
The workflows build and package binance-replay-parquet-materializer. The Dockerfile installs it in the runtime image.
Release artifact and image verification
.github/scripts/*, .github/workflows/acr-publish.yml, .github/workflows/ploy-ci.yml
Release manifests, executable-mode checks, contract tests, and image smoke tests include the seventh binary.
Research image inventory
deployment/aliyun/research/README.md
The documented entrypoint count increases from six to seven.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely identifies packaging the Spot replay materializer in the research runner.
Description check ✅ Passed The description includes every required template section and provides specific scope, validation, dependency, rollout, and rollback details.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/spot-admission-image-691

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a56ca0156a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/acr-publish.yml
@proerror77
proerror77 enabled auto-merge (squash) August 4, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant