runtime(research): package Spot replay materializer in runner - #692
Conversation
|
Warning Review limit reached
Next review available in: 48 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe research image now builds, packages, installs, and validates ChangesResearch binary integration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a56ca0156a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Change contract
Add the existing
binance-replay-parquet-materializerto every existing research-runner release and image contract surface: binary build/install, executable allowlist, exact release manifest/count, mode restore, Dockerfile packaging, CI/post-push probes, focused fixtures, and the Aliyun research operator inventory. Materializer behavior and dependencies remain unchanged.Issue relationship
Refs #691
Out of scope
No materializer behavior change, dependency, ACK Job/Pod, Aliyun executor, source-byte access, verifier/materialization workload, research/backtest, production collector/ECS, ClickHouse adoption, PM, Paper, Shadow, Live, or order path.
Dependencies and merge order
None. This PR is based directly on exact
origin/main@112d2b24fbb87d95a47534b785ec81131ef443afand is the independent image-contract unit before the #691 executor gate.Focused validation
Remote CI must build the exact head, verify exactly seven executable release files with bound SHA-256 entries, restore executable modes, build the prebuilt image, and probe
/usr/local/bin/binance-replay-parquet-materializer --help. No local Cargo, Docker, image, or data workload is used.Rollout and rollback
No production rollout. Revert the single PR commit to remove the seventh research entrypoint; the separate immutable ACR publish and Aliyun executor remain gated on the merged source revision.
Scope exception
None.