security: remove rkyv 0.7 from workspace locks - #705
Conversation
|
Warning Review limit reached
Next review available in: 25 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughBoth Rust manifests add Cargo patch overrides for ChangesDependency source pinning
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35b1cb54ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@rust_hft/prediction-markets/crates/ploy-research/prediction-policy-dependencies.linux.txt`:
- Around line 4-5: Regenerate the prediction policy graph from the patched
workspace before updating the input hashes. Ensure
prediction-policy-dependencies.linux.txt records the pinned Git sources and
revisions for rust_decimal and sqlx, replacing their registry sources; verify
the generated snapshot passes the provided cargo metadata and registry-source
checks.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: e0e4dc03-876e-4166-8f66-932ef8e52639
📒 Files selected for processing (3)
rust_hft/prediction-markets/crates/ploy-research/prediction-policy-dependencies.linux.sha256rust_hft/prediction-markets/crates/ploy-research/prediction-policy-dependencies.linux.txtrust_hft/prediction-markets/tests/workspace_runtime_retirement.rs
Summary
Removes the vulnerable rkyv 0.7 resolution from both audited Monday workspaces by pinning rust_decimal to the reviewed fork commit
4f7bc6f02d7920b6416988914ae86d25f6670b22(rust_decimal 1.42.1 with rkyv >=0.8.17) and regenerating the corresponding lockfiles plus the reviewed prediction-policy graph inputs.Issue relationship
Closes #694
Scope
Changed exactly seven files:
rust_hft/Cargo.tomlrust_hft/Cargo.lockrust_hft/prediction-markets/Cargo.tomlrust_hft/prediction-markets/Cargo.lockrust_hft/prediction-markets/crates/ploy-research/prediction-policy-dependencies.linux.txtrust_hft/prediction-markets/crates/ploy-research/prediction-policy-dependencies.linux.sha256rust_hft/prediction-markets/tests/workspace_runtime_retirement.rsThe resulting lock graphs contain no rkyv 0.7, rsa, or sqlx-mysql package. No audit ignore/allow, gate, runtime, collector, ACK/CEX, OSS, or production changes are included.
Remote validation (Aliyun task root)
422932065af94e3da00189e9ae12780aa0cacbd22417b457a83261730345c706, vulnerabilities 0.79c42453dea17afc72b350ec71197c985cea93f1f441de30cfd8c8c3ef230d50, vulnerabilities 0.ploytests: 18 passed, 0 failed; doc-tests 0.workspace_runtime_retirementintegration regressions: 18 passed, 0 failed; the temporary fixture now carries the pinned rust_decimal patch.ploy-researchfeature check passed with the refreshed policy graph/canonical hash.-D warnings.Production/runtime deployment is intentionally out of scope.
Summary by CodeRabbit