Skip to content

security: remove rkyv 0.7 from workspace locks - #705

Merged
proerror77 merged 7 commits into
mainfrom
codex/issue-694-rkyv-security-minimal
Aug 5, 2026
Merged

security: remove rkyv 0.7 from workspace locks#705
proerror77 merged 7 commits into
mainfrom
codex/issue-694-rkyv-security-minimal

Conversation

@proerror77

@proerror77 proerror77 commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Summary

Removes the vulnerable rkyv 0.7 resolution from both audited Monday workspaces by pinning rust_decimal to the reviewed fork commit 4f7bc6f02d7920b6416988914ae86d25f6670b22 (rust_decimal 1.42.1 with rkyv >=0.8.17) and regenerating the corresponding lockfiles plus the reviewed prediction-policy graph inputs.

Issue relationship

Closes #694

Scope

Changed exactly seven files:

  • rust_hft/Cargo.toml
  • rust_hft/Cargo.lock
  • rust_hft/prediction-markets/Cargo.toml
  • rust_hft/prediction-markets/Cargo.lock
  • rust_hft/prediction-markets/crates/ploy-research/prediction-policy-dependencies.linux.txt
  • rust_hft/prediction-markets/crates/ploy-research/prediction-policy-dependencies.linux.sha256
  • rust_hft/prediction-markets/tests/workspace_runtime_retirement.rs

The resulting lock graphs contain no rkyv 0.7, rsa, or sqlx-mysql package. No audit ignore/allow, gate, runtime, collector, ACK/CEX, OSS, or production changes are included.

Remote validation (Aliyun task root)

  • rust_hft cargo-audit JSON: 422932065af94e3da00189e9ae12780aa0cacbd22417b457a83261730345c706, vulnerabilities 0.
  • prediction-markets cargo-audit JSON: 79c42453dea17afc72b350ec71197c985cea93f1f441de30cfd8c8c3ef230d50, vulnerabilities 0.
  • RUSTSEC-2026-0235 and RUSTSEC-2023-0071 absent from both audit graphs.
  • hft-collector tests: 299 passed, 0 failed, 2 ignored; secondary suite 72 passed.
  • prediction ploy tests: 18 passed, 0 failed; doc-tests 0.
  • workspace_runtime_retirement integration regressions: 18 passed, 0 failed; the temporary fixture now carries the pinned rust_decimal patch.
  • research-heavy ploy-research feature check passed with the refreshed policy graph/canonical hash.
  • hft-collector and prediction Clippy passed with -D warnings.
  • final archive-to-source diff contains exactly the seven approved files; added-line diff-check passed.
  • The full workspace fmt check reports only pre-existing unrelated Rust files; no Rust source is changed by this PR. No formatting changes were made outside the four-file scope.
  • Task-scoped zstd v1.5.1 was used for verification; it was not installed system-wide or committed.

Production/runtime deployment is intentionally out of scope.

Summary by CodeRabbit

  • Chores
    • Updated underlying package sources to pinned revisions for improved security and consistency.
    • Applied consistent dependency source updates across related project components and test fixtures.
    • Refreshed Linux dependency manifests and checksums to match the updated packages.
    • Improved reproducibility of dependency resolution across supported project environments.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 25 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a406c8dd-2278-47fc-adbd-c7e18a583d09

📥 Commits

Reviewing files that changed from the base of the PR and between 67cc630 and a717d3a.

📒 Files selected for processing (4)
  • rust_hft/prediction-markets/config/research_missions/polymarket-btc-5m.example.json
  • rust_hft/prediction-markets/config/research_missions/polymarket-sol-5m.example.json
  • rust_hft/prediction-markets/crates/ploy-research/prediction-policy-dependencies.linux.sha256
  • rust_hft/prediction-markets/crates/ploy-research/prediction-policy-dependencies.linux.txt
📝 Walkthrough

Walkthrough

Both Rust manifests add Cargo patch overrides for sqlx and rust_decimal. The compiler-seal fixture adds a matching rust_decimal override. The Linux dependency snapshot hashes are updated.

Changes

Dependency source pinning

Layer / File(s) Summary
Cargo dependency source overrides
rust_hft/Cargo.toml, rust_hft/prediction-markets/Cargo.toml, rust_hft/prediction-markets/tests/workspace_runtime_retirement.rs
The manifests pin sqlx and rust_decimal to Git revisions. The compiler-seal fixture pins rust_decimal to a matching Git revision.
Linux dependency snapshot refresh
rust_hft/prediction-markets/crates/ploy-research/prediction-policy-dependencies.linux.*
The recorded Cargo input hashes and dependency archive SHA-256 checksum are updated.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

  • proerror77/monday#695: This PR changes prediction-markets dependency resolution, including sqlx source pinning.

Possibly related PRs

  • proerror77/monday#76: Both changes update the checked-in Linux prediction-policy dependency manifest and checksum.
  • proerror77/monday#137: Both changes update the same ploy-research dependency snapshot files.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the primary security change: removing the rkyv 0.7 resolution from workspace locks.
Description check ✅ Passed The description covers the change, issue relationship, scope, validation, exclusions, and production impact, with only minor template-heading omissions.
Linked Issues check ✅ Passed The changes satisfy issue #694 by removing rkyv 0.7, preserving audit controls, adding regression evidence, and avoiding excluded production and CI changes.
Out of Scope Changes check ✅ Passed The manifest, lockfile, dependency-graph, checksum, and fixture updates directly support issue #694 and contain no unrelated production or runtime changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/issue-694-rkyv-security-minimal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 35b1cb54ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rust_hft/prediction-markets/Cargo.lock

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@rust_hft/prediction-markets/crates/ploy-research/prediction-policy-dependencies.linux.txt`:
- Around line 4-5: Regenerate the prediction policy graph from the patched
workspace before updating the input hashes. Ensure
prediction-policy-dependencies.linux.txt records the pinned Git sources and
revisions for rust_decimal and sqlx, replacing their registry sources; verify
the generated snapshot passes the provided cargo metadata and registry-source
checks.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e0e4dc03-876e-4166-8f66-932ef8e52639

📥 Commits

Reviewing files that changed from the base of the PR and between 35b1cb5 and 67cc630.

📒 Files selected for processing (3)
  • rust_hft/prediction-markets/crates/ploy-research/prediction-policy-dependencies.linux.sha256
  • rust_hft/prediction-markets/crates/ploy-research/prediction-policy-dependencies.linux.txt
  • rust_hft/prediction-markets/tests/workspace_runtime_retirement.rs

@proerror77
proerror77 merged commit da438f1 into main Aug 5, 2026
52 checks passed
@proerror77
proerror77 deleted the codex/issue-694-rkyv-security-minimal branch August 5, 2026 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(security): remove vulnerable rkyv 0.7 resolution from Cargo Audit

1 participant