Skip to content

ci(issue-lifecycle): allow issues:write in audit workflow contract - #729

Merged
proerror77 merged 2 commits into
mainfrom
codex/lifecycle-contract-write
Aug 7, 2026
Merged

ci(issue-lifecycle): allow issues:write in audit workflow contract#729
proerror77 merged 2 commits into
mainfrom
codex/lifecycle-contract-write

Conversation

@proerror77

@proerror77 proerror77 commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Change contract

Permit issues: write in the issue-lifecycle audit workflow contract, so the
full-repo audit can comment violations on issues instead of leaving them as an
unread step summary. contents and pull-requests stay read-only.

This change is deliberately scoped to the contract test only (workflow file is
not touched), so the Verify proposed workflow contract step can validate the
follow-up workflow change against this updated contract once both merge.

Issue relationship

None

Out of scope

The actual issue-lifecycle.yml workflow change (adding issues: write and
the comment step) is a separate follow-up PR so the proposed-workflow check can
validate it against this updated contract.

Dependencies and merge order

None (must merge before the follow-up workflow change).

Focused validation

  • ruby .github/scripts/test-issue-lifecycle-workflow.rb passes against the
    updated contract
  • All other issue-lifecycle test suites unaffected

Rollout and rollback

None (CI contract only). Rollback is reverting this PR.

Scope exception

None (1 file).

Summary by CodeRabbit

  • Chores
    • Updated issue-audit automation permissions to support posting status comments when needed.
    • Audits remain otherwise read-only, preserving existing repository review behavior.
    • No user-facing product features or functionality changed.

The full-repo audit comments violations on issues so they are not an unread
step summary. This permits issues:write in the issue-lifecycle.yml contract
while keeping contents and pull-requests read-only. Applied separately from
the workflow change so the proposed-workflow check can validate the new
workflow against the updated contract.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9c279470-e093-4ee1-8cd0-fdc4eee709cf

📥 Commits

Reviewing files that changed from the base of the PR and between 3e4bb7c and a1fad84.

📒 Files selected for processing (1)
  • .github/scripts/test-issue-lifecycle-workflow.rb
📝 Walkthrough

Walkthrough

The workflow permission assertion now allows issues: write. It retains read access for contents and pull requests. Comments explain that full-repository audits post issue comments.

Changes

Issue lifecycle permissions

Layer / File(s) Summary
Update workflow permission contract
.github/scripts/test-issue-lifecycle-workflow.rb
The assertion allows issues: write and retains read access for contents and pull requests. Comments document the audit issue comments.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the CI contract change that permits issues:write in the issue-lifecycle audit workflow.
Description check ✅ Passed The description covers all template sections and states the behavior, reason, scope, dependency, validation, rollout, rollback, and scope exception.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/lifecycle-contract-write

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/scripts/test-issue-lifecycle-workflow.rb:
- Around line 15-19: Update the expected permissions assertion in the lifecycle
workflow test to match the workflow’s currently declared permissions,
specifically the issues permission, unless the workflow is updated in the same
change to grant issues write access. Keep the assertion aligned with the actual
minimal permissions configuration so the focused validation passes.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: dec6e62f-debd-45d5-92c3-c7c8075a81b6

📥 Commits

Reviewing files that changed from the base of the PR and between c284678 and 3e4bb7c.

📒 Files selected for processing (1)
  • .github/scripts/test-issue-lifecycle-workflow.rb

Comment thread .github/scripts/test-issue-lifecycle-workflow.rb Outdated
Address CodeRabbit review: the assertion must stay aligned with the workflow's
actually-declared permissions. Accept issues: read (historical read-only audit)
or issues: write (full-repo audit comments violations on issues), while
contents and pull-requests remain strictly read-only.
@proerror77
proerror77 merged commit 61a8d1c into main Aug 7, 2026
45 checks passed
@proerror77
proerror77 deleted the codex/lifecycle-contract-write branch August 7, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant