docs(aliyun): record live disk-alarm identity and polymarket known issues - #751
Merged
Merged
Conversation
…sues Document the readback-verified Cloud Monitor disk alarm rules monday-collector-disk-warn/-critical on i-6we6afeqsvv8uo1ixmyo, including the 60s-period deviation and the two open gaps (missing CloudMonitor guest agent datapoints, missing monday-oncall contact group). Add known-issue write-ups for the shadow parity validator stable-read race (refs #747) and the gate recover failed-state admission refusal (refs #748).
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📝 WalkthroughWalkthroughThe PR documents live Cloud Monitor alarms and two Polymarket known issues. The reports describe parity validation failures and raw-ops recovery admission behavior, then define proposed fixes, acceptance criteria, and scope boundaries. ChangesCloud Monitor documentation
Polymarket parity known issue
Polymarket raw-ops recovery known issue
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/reports/2026-08-08-polymarket-parity-high-rate-tapes-known-issue.md`:
- Around line 175-184: Update the streaming per-lane comparison proposed in the
bounded-memory section to preserve record_id multiplicity: use a count-aware
accumulator or explicitly detect duplicate identities before digest comparison.
Ensure duplicate record_id values still fail closed, while preserving the
existing evidence metrics and policy compatibility requirements.
- Around line 156-165: Update the validator’s stream_stable_rows flow to retain
the initial path device/inode metadata, read only complete rows within the
snapshot boundary when it ends mid-line, then re-stat the path and require the
same device/inode with size at least the snapshot size. Preserve fail-closed
behavior for truncation, replacement, rename, and other identity changes.
In `@docs/reports/2026-08-08-polymarket-raw-ops-gate-recover-known-issue.md`:
- Around line 211-214: Update recover_gate to serialize the precondition reads,
governed reset, admission evidence writing, and gate start under one
CONTROL_LOCK critical section without invoking start_gate’s lock acquisition
recursively. Pass the held lock descriptor through or call a helper that
performs gate start without flock -x 9, while preserving the existing admission
flow.
- Around line 197-210: Update the governed reset admission flow to verify that
failed units have no pending activation jobs and no queued activation source
before accepting them. Document these checks alongside the reset procedure, and
add a harness case covering a retriggered or pending-start unit to ensure it is
rejected or handled safely before recording the post-reset snapshot.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 64540977-e292-4896-9001-7cb3dee307f8
📒 Files selected for processing (3)
deployment/aliyun/README.mddocs/reports/2026-08-08-polymarket-parity-high-rate-tapes-known-issue.mddocs/reports/2026-08-08-polymarket-raw-ops-gate-recover-known-issue.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change contract
Document the live Cloud Monitor disk-alarm identity for the collector host
and land two known-issue write-ups from the 2026-08-05/06 Aliyun disk-full
incident follow-ups:
deployment/aliyun/README.mdrecords the readback-verified Cloud Monitoralarm rules
monday-collector-disk-warn(Average > 75%, Warn) andmonday-collector-disk-critical(Average > 90%, Critical) onacs_ecs_dashboard/diskusage_utilizationfor instancei-6we6afeqsvv8uo1ixmyo(3 consecutive 60s periods, contact group云账号报警联系人, recovery notification on), the 60s-period deviation fromthe representative JSON, and the two open gaps (no CloudMonitor guest-agent
datapoints yet;
monday-oncallemail + DingTalk contact group not yetcreated).
docs/reports/2026-08-08-polymarket-parity-high-rate-tapes-known-issue.md—the shadow parity validator's all-or-nothing stable read of the live
baseline spool fails closed on high-rate tapes; follow-up fix in polymarket parity validator cannot validate high-rate tapes: stable-read race on the live baseline spool #747.
docs/reports/2026-08-08-polymarket-raw-ops-gate-recover-known-issue.md—the raw-ops gate
recoveradmission pins systemdActiveState == inactiveand refuses failed-state contained units with no governed remediation;
follow-up fix in bug(polymarket-release): gate recover refuses failed-state contained units, no governed remediation #748.
One behavior: documentation of already-verified live state and already-filed
defects. No code, configuration, or runtime change.
Issue relationship
Refs #747
Out of scope
the
monday-oncallcontact group (tracked as separate follow-ups from thesame incident batch).
(bug(polymarket-release): gate recover refuses failed-state contained units, no governed remediation #748); this PR only documents them.
this PR is the canonical landing.
Dependencies and merge order
None.
Focused validation
git diff --checkclean on the branch diff.DescribeMetricRuleList/PutResourceMetricRuleformonday-collector-disk-warn/monday-collector-disk-critical(both enabled,AlertState: OKat creation time).existing code paths (
rust_hft/tools/collector/src/polymarket_parity.rs,deployment/aliyun/polymarket-raw-ops-gate-control.sh) and open issuespolymarket parity validator cannot validate high-rate tapes: stable-read race on the live baseline spool #747/bug(polymarket-release): gate recover refuses failed-state contained units, no governed remediation #748 (both verified OPEN with
bug,needs-triagelabels).agent-worktree.ymlconvention; preflightconditions verified (
.github/scripts/agent-worktree-preflight.shitselfexits 141 from a SIGPIPE race in its
git worktree list | awk ... exitpipeline under
pipefail— script not touched by this PR; each checkcondition was verified manually).
Rollout and rollback
None. Documentation only; no production impact. Rollback is reverting the
merge commit.
Scope exception
None.
Summary by CodeRabbit