Skip to content

fix(alpha): require registered MCTS baseline policy - #764

Merged
proerror77 merged 1 commit into
mainfrom
codex/cex-mcts-policy-readback-665
Aug 9, 2026
Merged

proerror77 merged 1 commit into
mainfrom
codex/cex-mcts-policy-readback-665

Conversation

@proerror77

@proerror77 proerror77 commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Change contract

Require the CEX MCTS consumer to read back the immutable baseline policy revision named by gate.policy_hash and fail closed on missing or drifted registry evidence before any Mission transition.

Issue relationship

Refs #580

Out of scope

Factor Bank, GP, the #601 MCTS adapter, holdout, runtime, data admission, research/backtest execution, deployment, and trading.

Dependencies and merge order

Supersedes #665. #670 is already merged. This repairs the remaining immutable-baseline admission gap discovered after child issue #600 was closed; #600 lifecycle metadata is intentionally unchanged until merge and exact-head readback complete.

Base is current main@5dc385553ad9df88d8acb34143a527ca4ae424b9.

Focused validation

  • Red counterexample: missing policy revision previously reached the Replace CEX formula-growing MCTS with Factor-Bank subset selection #601 adapter refusal instead of failing registry admission.
  • cargo test -p alpha-harness --locked mission_runner::tests::mcts_rejects_missing_or_tampered_baseline_policy_revision_before_transition -- --exact (1 passed)
  • cargo test -p alpha-harness --locked (136 passed)
  • cargo clippy -q -p alpha-harness --locked --all-targets -- -D warnings
  • cargo fmt -p alpha-harness -- --check
  • git diff --check
  • Missing, wrong-kind, wrong-Mission-parent, and tampered typed policy revisions keep the consumer Mission Pending with zero iterations.
  • Two independent final-head reviews passed: Standards (no findings) and Spec (PASS).

Rollout and rollback

Research control-plane admission only. No MCTS search is enabled and no external runtime or data resource is touched. Roll back this single commit if needed.

Scope exception

None.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 16 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2f93c516-099e-4a4d-9dad-5e46d4971726

📥 Commits

Reviewing files that changed from the base of the PR and between 5dc3855 and 45dfd66.

📒 Files selected for processing (2)
  • rust_hft/alpha-harness/app/src/mission.rs
  • rust_hft/alpha-harness/app/src/mission_runner.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 45dfd66046

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rust_hft/alpha-harness/app/src/mission.rs
@proerror77
proerror77 enabled auto-merge (squash) August 9, 2026 03:18
@proerror77
proerror77 merged commit 1e74bf4 into main Aug 9, 2026
48 of 51 checks passed
@proerror77
proerror77 deleted the codex/cex-mcts-policy-readback-665 branch August 9, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant