fix(alpha): require registered MCTS baseline policy - #764
Conversation
|
Warning Review limit reached
Next review available in: 16 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45dfd66046
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Change contract
Require the CEX MCTS consumer to read back the immutable baseline policy revision named by
gate.policy_hashand fail closed on missing or drifted registry evidence before any Mission transition.Issue relationship
Refs #580
Out of scope
Factor Bank, GP, the #601 MCTS adapter, holdout, runtime, data admission, research/backtest execution, deployment, and trading.
Dependencies and merge order
Supersedes #665. #670 is already merged. This repairs the remaining immutable-baseline admission gap discovered after child issue #600 was closed; #600 lifecycle metadata is intentionally unchanged until merge and exact-head readback complete.
Base is current
main@5dc385553ad9df88d8acb34143a527ca4ae424b9.Focused validation
cargo test -p alpha-harness --locked mission_runner::tests::mcts_rejects_missing_or_tampered_baseline_policy_revision_before_transition -- --exact(1 passed)cargo test -p alpha-harness --locked(136 passed)cargo clippy -q -p alpha-harness --locked --all-targets -- -D warningscargo fmt -p alpha-harness -- --checkgit diff --checkRollout and rollback
Research control-plane admission only. No MCTS search is enabled and no external runtime or data resource is touched. Roll back this single commit if needed.
Scope exception
None.