Skip to content

fix(deploy): safely cut over USD-M reference V3 - #775

Merged
proerror77 merged 16 commits into
mainfrom
codex/binance-usdm-reference-v3-cutover
Aug 9, 2026
Merged

proerror77 merged 16 commits into
mainfrom
codex/binance-usdm-reference-v3-cutover

Conversation

@proerror77

Copy link
Copy Markdown
Owner

Change contract

Upgrade one healthy digest-addressed Binance USD-M Reference host from V2 to V3 without stranding either schema in the local spool.

Issue relationship

Refs #773

Out of scope

Reference schema contents, PIT materialization, authenticated fees, execution telemetry, and Live trading.

Dependencies and merge order

Stacked on #774. Merge only after #774 lands, then retarget this PR to main and require exact-head CI again.

Focused validation

  • shellcheck passed for cutover and host-gate scripts
  • existing-host behavior test executes the real rollback function with mocked production effects
  • failed V3 drain prevents V2 restoration
  • successful V3 drain and empty-lake proof precede restoration
  • reference host-gate and release-contract tests passed
  • worktree preflight and diff check passed

Rollout and rollback

Require one named controller and one immutable shadow gate. Bind the existing uploader sidecar, approved OSS destination, and rollback assets by SHA-256; stop V2; drain V2 to an empty lake; then switch and prove a V3 OSS round trip. If the candidate may have written, rollback first drains V3. Failure to prove an empty lake leaves services fail-closed.

Scope exception

None.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@proerror77, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 15 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d6426a63-c33d-4c42-bd2d-98fa65d09bbf

📥 Commits

Reviewing files that changed from the base of the PR and between 8b93efc and a524332.

📒 Files selected for processing (4)
  • agent-worktree.yml
  • deployment/aliyun/README.md
  • deployment/aliyun/binance-usdm-reference-cutover.sh
  • deployment/aliyun/test-binance-usdm-reference-host-gate.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 725bd14be7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread deployment/aliyun/binance-usdm-reference-cutover.sh Outdated
Comment thread deployment/aliyun/binance-usdm-reference-cutover.sh Outdated
Comment thread deployment/aliyun/binance-usdm-reference-cutover.sh
Comment thread deployment/aliyun/binance-usdm-reference-cutover.sh
Comment thread deployment/aliyun/binance-usdm-reference-cutover.sh Outdated
Comment thread deployment/aliyun/binance-usdm-reference-cutover.sh
Base automatically changed from codex/binance-usdm-reference-v3-upgrade to main August 9, 2026 15:40
…ference-v3-cutover

# Conflicts:
#	agent-worktree.yml
#	rust_hft/tools/collector/src/bin/binance-usdm-reference-artifact-verifier.rs
@proerror77
proerror77 enabled auto-merge (squash) August 9, 2026 15:45
@proerror77
proerror77 merged commit 2e927fc into main Aug 9, 2026
45 checks passed
@proerror77
proerror77 deleted the codex/binance-usdm-reference-v3-cutover branch August 9, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant