fix(collector): reserve CPU for reference deadline - #78
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe reference collector services now reserve up to 80% CPU. Documentation records the unchanged 180-second deadline, and Rust CI verifies the pinned CPU quota alongside existing memory limits. ChangesCollector resource envelope
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change contract
Raise the Polymarket reference collector and its shadow unit from 20% to 80% CPU quota so observed collection work can be scheduled within the existing 180-second fail-closed deadline.
Acceptance evidence
124exits after about 6m40s; no memory/OOM events; sustained CPU cgroup throttling.cargo test -p hft-collector --features collector-binance --locked(107 passed, 1 network-dependent test ignored).cargo clippy -p hft-collector --all-targets --features collector-binance --no-deps --locked -- -D warnings.deployment/aliyun/test-polymarket-raw-ops-control-plane.sh.Out of scope
No change to the 180-second watchdog, data completeness rules, memory limits, collector request policy, upload behavior, or any execution/live-trading path.
Dependency or merge order
None. The production and shadow systemd units must be released together through the existing immutable collector control-bundle workflow.
Focused validation
The acceptance evidence above is the focused validation for this collector/control-plane change.
Rollout/rollback impact
After merge, build the approved Linux artifact/control bundle, run the candidate-specific reference shadow gate, then cut over only with its immutable passing evidence. Roll back through the prior immutable control bundle if the gate fails; do not relax the health policy or bypass the gate.
Summary by CodeRabbit