feat(research): materialize aggregate trade flow - #783
Conversation
…ntract-v2 # Conflicts: # agent-worktree.yml
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe worktree contract now targets LOB PIT trade features. PIT materialization filters aggregate trades by symbol and interval, computes trade features, emits both LOB and TradeTick modalities, and validates the output. ChangesPIT trade-feature materialization
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Materializer
participant AggregateTrades
participant PITRows
Materializer->>AggregateTrades: Filter by symbol and sample interval
AggregateTrades-->>Materializer: Return trade aggregates
Materializer->>PITRows: Emit LOB and TradeTick features
Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…eatures # Conflicts: # agent-worktree.yml # rust_hft/research-core/manifest/src/lib.rs
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Change contract
Materialize authenticated aggregate-trade count, volume, notional, and signed flow into each PIT LOB row so the declared trade modality is actually consumable by Spot and USD-M HFT research.
Issue relationship
Refs #779
Out of scope
ResearchSnapshot V2 fee, funding/OI, and realized latency evidence binding; those remain in the next stacked rollout unit.
Dependencies and merge order
Depends on #781. Merge #781 first, then retarget this PR to main.
Focused validation
Rollout and rollback
No runtime mutation. Rollback is the single commit; current production collectors and uploaders are untouched.
Scope exception
None.
Summary by CodeRabbit